Move log warning about non-namespaced stacktraces

PiperOrigin-RevId: 553472372 Change-Id: Iba43cba78edd1826afb29f49a7e08e919554ed80
google · Aug 3, 2023 · 4d625e5 · 4d625e5
1 parent 3f9e9a2
commit 4d625e5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/sandboxed_api/sandbox2/policybuilder.cc b/sandboxed_api/sandbox2/policybuilder.cc
@@ -1213,11 +1213,6 @@ absl::StatusOr<std::unique_ptr<Policy>> PolicyBuilder::TryBuild() {
     output->SetNamespace(std::make_unique<Namespace>(
         allow_unrestricted_networking_, std::move(mounts_), hostname_,
         allow_mount_propagation_));
-  } else {
-    // Not explicitly disabling them here as this is a technical limitation in
-    // our stack trace collection functionality.
-    LOG(WARNING) << "Using policy without namespaces, disabling stack traces on"
-                 << " crash";
   }
 
   output->collect_stacktrace_on_signal_ = collect_stacktrace_on_signal_;

diff --git a/sandboxed_api/sandbox2/sandbox2.h b/sandboxed_api/sandbox2/sandbox2.h
@@ -23,6 +23,8 @@
 #include <utility>
 
 #include "absl/base/macros.h"
+#include "absl/log/check.h"
+#include "absl/log/log.h"
 #include "absl/status/statusor.h"
 #include "sandboxed_api/sandbox2/comms.h"
 #include "sandboxed_api/sandbox2/executor.h"
@@ -46,6 +48,10 @@ class Sandbox2 final {
         notify_(std::move(notify)) {
     CHECK(executor_ != nullptr);
     CHECK(policy_ != nullptr);
+    // This is a technical limitation in our stack trace collection
+    // functionality.
+    LOG(WARNING) << "Using policy without namespaces, disabling stack traces on"
+                 << " crash";
   }
 
   Sandbox2(const Sandbox2&) = delete;