Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build pip wheel in wrapper cmake #94

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

figroc
Copy link

@figroc figroc commented Nov 21, 2019

The original CMakeLists.txt for python installs the lib and py files directly to python site. They are not versioned and the installation dir is affected by CMAKE_INSTALL_PREFIX. While the latter is not necessary bad, the former definitely is and it's bad for redistribution. This PR is partially related to #93.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@figroc
Copy link
Author

figroc commented Nov 21, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@figroc figroc force-pushed the build-pip-wheel branch 2 times, most recently from f13b3b1 to 7a1778f Compare November 21, 2019 16:59
@figroc figroc changed the title build pip wheel build pip wheel in wrapper cmake Dec 27, 2019
@cheng-chi
Copy link

@figroc @jmr Is there any plan to merge this branch?

@calestyo
Copy link

calestyo commented Jul 2, 2020

anything new on this?

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@jmr
Copy link
Member

jmr commented Sep 11, 2020

Can you resolve the conflicts?

@figroc figroc force-pushed the build-pip-wheel branch 3 times, most recently from 754d2b2 to aa63f91 Compare September 14, 2020 05:45
@jmr
Copy link
Member

jmr commented Sep 14, 2020

CI is failing: https://travis-ci.org/github/google/s2geometry/jobs/726922409#L873

It looks like setuptools needs to be installed first. Can you update README.md with new python build instructions and update .travis.yml to do pip install setuptools?

src/python/CMakeLists.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants