-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build pip wheel in wrapper cmake #94
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
f13b3b1
to
7a1778f
Compare
7a1778f
to
625bced
Compare
anything new on this? |
Can you resolve the conflicts? |
754d2b2
to
aa63f91
Compare
CI is failing: https://travis-ci.org/github/google/s2geometry/jobs/726922409#L873 It looks like |
9683d82
to
b53c471
Compare
5807c19
to
1776827
Compare
The original
CMakeLists.txt
for python installs the lib and py files directly to python site. They are not versioned and the installation dir is affected byCMAKE_INSTALL_PREFIX
. While the latter is not necessary bad, the former definitely is and it's bad for redistribution. This PR is partially related to #93.