Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2CellUnionTests Line 258-260 should be removed. #1

Open
GoogleCodeExporter opened this issue Sep 25, 2015 · 0 comments
Open

S2CellUnionTests Line 258-260 should be removed. #1

GoogleCodeExporter opened this issue Sep 25, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

Line 258-260 as below should be removed:

            if (!u.contains(xId)) {
              u.getIntersection(xCells, yId);
            }

It is extraneous and guarantees the subsequent assertTrue(u.contains(xId)); on 
line 261 will always work even though this is the line that is being ultimately 
tested.

Original issue reported on code.google.com by [email protected] on 9 Jul 2013 at 1:39

lokkju pushed a commit to lokkju/s2-geometry-library-java that referenced this issue Feb 1, 2019
Formatting updates, documentation clarifications and fixes, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant