Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new flag Pattern.LONGEST_MATCH ... #97

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

mykeul
Copy link
Contributor

@mykeul mykeul commented Dec 5, 2019

... to allow changing hard-coded "longest=false" in Pattern.compile()

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sjamesr
Copy link
Contributor

sjamesr commented Dec 5, 2019

Thank you, looks good! Do you mind running the code formatter and rebasing your change?

./gradlew googleJavaFormat from the project root dir should do the trick

@mykeul mykeul force-pushed the longest-match-flag branch from 36d8ac3 to 1c00a62 Compare December 5, 2019 15:22
@mykeul
Copy link
Contributor Author

mykeul commented Dec 5, 2019

You're welcome. Formatted, rebased, pushed. I'm looking at the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 278

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 94.049%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/google/re2j/java/com/google/re2j/Pattern.java 9 87.67%
Totals Coverage Status
Change from base Build 277: 0.002%
Covered Lines: 2987
Relevant Lines: 3176

💛 - Coveralls

@mykeul
Copy link
Contributor Author

mykeul commented Dec 5, 2019

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Dec 5, 2019
@sjamesr
Copy link
Contributor

sjamesr commented Dec 5, 2019

Thank you!

@sjamesr sjamesr merged commit 9708be1 into google:master Dec 5, 2019
@mykeul mykeul deleted the longest-match-flag branch December 5, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants