Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3 shebangs #350

Closed
psaiz opened this issue Jan 12, 2022 · 1 comment
Closed

Python3 shebangs #350

psaiz opened this issue Jan 12, 2022 · 1 comment

Comments

@psaiz
Copy link

psaiz commented Jan 12, 2022

There are two files in this repo that have a shebang like #!/usr/bin/python. That causes issues while packaging them in an rpm. Would it be possible to put #!/usr/bin/python3?

*** ERROR: ambiguous python shebang in ./re2/make_unicode_casefold.py: #!/usr/bin/python. Change it to python3 (or python2) explicitly.
*** ERROR: ambiguous python shebang in ./re2/make_unicode_groups.py: #!/usr/bin/python. Change it to python3 (or python2) explicitly.

The two files are:

https://github.com/google/re2/blob/main/re2/make_unicode_casefold.py
https://github.com/google/re2/blob/main/re2/make_unicode_groups.py

Thanks
@psaiz psaiz mentioned this issue Jan 12, 2022
Closed
@junyer
Copy link
Contributor

junyer commented Jan 12, 2022

Sure, no problem.

@psaiz psaiz mentioned this issue Jan 12, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Jan 12, 2022
@junyer
Use Python 3 shebangs for make_unicode_*.py.
154a2c1 
Fixes #350.

Change-Id: I0a2b76da3a1d5190f50b34db215329b773a342cf
Reviewed-on: https://code-review.googlesource.com/c/re2/+/59551
Reviewed-by: Perry Lorier <[email protected]>
Reviewed-by: Paul Wankadia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junyer @psaiz