This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 164
Feature/assoc demo #72
Open
tkaitchuck
wants to merge
71
commits into
master
Choose a base branch
from
feature/assoc-demo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick mode only requires 2 LASSO calls for estimating std dev instead of 5. Minor changes in several places including modifications to the test suite and assoc test params.
- Contains code fragments to experiment with EM - More metrics reported (support recovered in Decode for each var) - Timing information (experimental) - Default params in assoc_sim are modified to match use cases closer - Different metrics presented in association test suite results page
- moved 2-way association code to its own file - moved specs related to assoctest to its own file - other minor changes
- moving some map code to read_input.R - analyze_assoc_expt now includes a verbose mode
- resolved conflicts - modified code to use new Encode interface - modified rappor_assoc_sim.py to use same interface as rappor_sim.py
Also, some minor refactoring.
- uncommented experimental code in decode2way and documented it - renamed function that processes assoc maps - deleted params.csv
- inverted noise matrix outside loop - renamed gen_assoc_reports - added its test to test.sh - make-summary now shows original dimensions for variables
- threw fitdistribution experimental code into separate function that is now only called by a flag passed to FitDistribution - flag added to assoctest.sh to run comparisons to EM - added package jsonlite to setup - further documentation added in sum_bits_assoc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #48 (closed due to cli error)