-
Notifications
You must be signed in to change notification settings - Fork 284
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Switch fully to argument-by-argument call matching for PyTDFunction.
* Groups matches by view so that multiple overloads work. * Gets rid of the "variable view" hack we were using to simultaneously support the old and new matching implementations. * Does a few performance optimizations to mitigate slowdowns caused by changes to CFG queries. This change was causing a few random slowdowns/timeouts by causing us to hit queries that are inexplicably slow. I simplified variables and avoided/delayed filtering in a few places to fix this. * Removes buggy enforcement of --strict-parameter-checks in matcher.compute_one_match. I'll re-implement this feature flag in a more correct manner at a later time. * Updates the subprocess overlay to work with the new matching implementation. PiperOrigin-RevId: 482701895
- Loading branch information
Showing
18 changed files
with
354 additions
and
289 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -144,6 +144,7 @@ py_library( | |
.mixin | ||
pytype.utils | ||
pytype.pytd.pytd | ||
pytype.typegraph.cfg | ||
) | ||
|
||
py_library( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.