Backport much of master to 1.9.x; KotlinCompile type, osdetector, lazy buildDir #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally on my laptop I cannot run many of the tests before they fail with out-of-memory. With this, I can run all the tests successfully. There does not seem to be a way to request forking directly. Instead, the docs warn about passing an environment because it will cause forking. In our case, that seems to be exactly what we want. I believe this is a workaround and only benefitting indirectly, but it works and is easy and I'll take what I can get.
* Use KotlinCompile type directly * Add Kotlin 1.7.20, Gradle 7.6 versions to tests * Fix codenarc issues * Do not run all gradleVersion * kotlinVersion combinations * Bump kotlin and agp versions
kotlin.bintray.com is dead and has an invalid certificate. repo.gradle.org was for gradle-kotlin-dsl which we're getting through plugins.gradle.org.
This causes the plugin to use the correct configuration when users
use a non-default buildDir.
Note that for IDEs we create directories in afterEvaluate{}. It is
possible for the user's own afterEvaluate{} to change buildDir. In that
case, the task will output to the 'correct' directory but the mkdirs for
IDEs can be the 'old' buildDir. But users shouldn't be using
afterEvaluate{}, so we don't care and there's no real fix anyway.
Fixes google#674
YifeiZhuang
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #655, #657, #664, #665, #676, #677