Support plugins without an ExecutableLocator #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This pull request is intended to fix #699 |
|
The problem is NamedDomainObjectCollection.getByName fails if not exist, while NamedDomainObjectCollection.findByName returns null and further filtered out - this makes it searching for system path. |
YifeiZhuang
approved these changes
May 9, 2023
ejona86
approved these changes
May 9, 2023
|
@ateirney, thank you! And sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading from 0.8.19 to 0.9.2 I was no longer able to use plugins that would be located using the system path.
The error that was given was the following.
> ExecutableLocator with name 'bq-schema' not found.This pull request attempts to enable that again by making the call that was resulting in an exception being thrown from occurring.