Wire proto sources/outputs/etc through ProtoSourceSet #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rougsig
changed the title
rougsig
commented
Oct 30, 2022
src/main/groovy/com/google/protobuf/gradle/ProtobufPlugin.groovy
Outdated
Show resolved
Hide resolved
rougsig
commented
Oct 30, 2022
src/test/groovy/com/google/protobuf/gradle/ProtobufKotlinDslPluginTest.groovy
Outdated
Show resolved
Hide resolved
rougsig
commented
Oct 30, 2022
src/main/groovy/com/google/protobuf/gradle/ProtobufPlugin.groovy
Outdated
Show resolved
Hide resolved
rougsig
force-pushed
the
feat/proto-sourceset
branch
3 times, most recently
from
bd42d4c
to
83dbd91
Compare
rougsig
force-pushed
the
feat/proto-sourceset
branch
from
293f152
to
4990241
Compare
Groovy type system problems
rougsig
commented
Nov 6, 2022
| project, | ||
| isTest, | ||
| protoDir, | ||
| protoDir.absolutePath.replace(project.rootDir.absolutePath, "").contains("build") |
rougsig
commented
Nov 6, 2022
| project, | ||
| isTest, | ||
| protoDir, | ||
| protoDir.absolutePath.replace(project.rootDir.absolutePath, "").contains("build") |
rougsig
commented
Nov 6, 2022
| project, | ||
| isTest, | ||
| outputDir, | ||
| outputDir.absolutePath.replace(project.rootDir.absolutePath, "").contains("build") |
rougsig
commented
Nov 6, 2022
| private void configureAndroidKotlinCompileTasks(BaseVariant variant, ProtoSourceSet protoSourceSet) { | ||
| project.plugins.withId("org.jetbrains.kotlin.android") { | ||
| project.afterEvaluate { | ||
| String compileKotlinTaskName = Utils.getKotlinAndroidCompileTaskName(project, variant.name) |
There was a problem hiding this comment.
getKotlinAndroidCompileTaskName can be moved to ProtoSourceSet
rougsig
force-pushed
the
feat/proto-sourceset
branch
from
3080003
to
3196f30
Compare
See details here google#631
rougsig
force-pushed
the
feat/proto-sourceset
branch
from
3196f30
to
7e4542a
Compare
Otherwise, gradle throw ClassNotFound exception
rougsig
force-pushed
the
feat/proto-sourceset
branch
from
8a1ef8d
to
f100c02
Compare
rougsig
commented
Nov 6, 2022
| .withPluginClasspath() | ||
| .withGradleVersion(gradleVersion) | ||
| .build() | ||
| BuildResult result = ProtobufPluginTestHelper.getGradleRunner( |
There was a problem hiding this comment.
move to separate PR
rougsig
commented
Nov 6, 2022
| // https://github.com/gradle/gradle/issues/6862 | ||
| //.withDebug(true) | ||
| .build() | ||
| BuildResult result = ProtobufPluginTestHelper.getGradleRunner( |
There was a problem hiding this comment.
move to separate PR
rougsig
commented
Nov 6, 2022
| import org.gradle.language.jvm.tasks.ProcessResources | ||
|
|
||
| @CompileDynamic | ||
| class AndroidExt { |
There was a problem hiding this comment.
Add comment: Temporarily hack. TODO: Move all AndroidExt to AndroidProtobufPlugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.