Fix a warning when there are only enums, no messages. #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we got:
```
...../build/enum_test/autogen/Proto/EnumOnly.hs:72:1: error: [-Wunused-top-binds, -Werror=unused-top-binds]
Defined but not used: ‘packedFileDescriptor’
|
72 | packedFileDescriptor
| ^^^^^^^^^^^^^^^^^^^^
```
The check for whether the file had any messages was incorrect, since it didn't account for enums which are tracked in the same map.
jinwoo
reviewed
Dec 5, 2019
| @@ -163,3 +165,5 @@ testAliases = testCase "alias" $ do | |||
|
|
|||
| testManyCases = | |||
| runTypedTest (roundTripTest "many cases" :: TypedTest ManyCasesProto) | |||
|
|
|||
| testLone = testCase "no messages" $ LONE @?= LONE | |||
There was a problem hiding this comment.
I'm not sure I understand this test. Isn't LONE always == LONE?
There was a problem hiding this comment.
Added a comment. The test is intentionally trivial; the goal is just to make this file import the other module to make sure it compiles properly.
jinwoo
approved these changes
Dec 5, 2019
| @@ -163,3 +165,5 @@ testAliases = testCase "alias" $ do | |||
|
|
|||
| testManyCases = | |||
| runTypedTest (roundTripTest "many cases" :: TypedTest ManyCasesProto) | |||
|
|
|||
| testLone = testCase "no messages" $ LONE @?= LONE | |||
avdv
pushed a commit
to avdv/proto-lens
that referenced
this pull request
Aug 9, 2023
Previously we got:
```
...../build/enum_test/autogen/Proto/EnumOnly.hs:72:1: error: [-Wunused-top-binds, -Werror=unused-top-binds]
Defined but not used: ‘packedFileDescriptor’
|
72 | packedFileDescriptor
| ^^^^^^^^^^^^^^^^^^^^
```
The check for whether the file had any messages was incorrect, since it didn't account for enums which are tracked in the same map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we got:
The check for whether the file had any messages was incorrect, since it didn't account for enums which are tracked in the same map.