Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kernel base to work for non-KASLR kernels. #904

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

gmarin13
Copy link
Contributor

Replace an existing check for "start >= loadSegment.Vaddr" with "start >= 0x8000000000000000".

The old condition was checking for the mapping start address to be greater or equal to the program segment Vaddr. However, for kernels without KASLR, the mapping start address (start) is less or equal the program header Vaddr. If the program header that includes the '.text' section is not the first segment, then the mapping start is strictly less than loadSegment.Vaddr.

Instead of removing the condition, we replace it with a check that start is in the kernel address space, so we don't take this path for user space binaries.

Adjusted the test case for PIE kernels to match actual addresses seen for a non-KASLR kernel. The new test fails with the old code and succeeds now.

Replace an existing check for "start >= loadSegment.Vaddr" with
"start >= 0x8000000000000000".

The old condition was checking for the mapping start address to be greater
or equal to the program segment Vaddr. However, for kernels without KASLR,
the mapping start address (start) is less or equal the program header Vaddr.
If the program header that includes the '.text' section is not the first
segment, then the mapping start is strictly less than loadSegment.Vaddr.

Instead of removing the condition, we replace it with a check that start is
in the kernel address space, so we don't take this path for user space
binaries.

Adjusted the test case for PIE kernels to match actual addresses seen for
a non-KASLR kernel. The new test fails with the old code and succeeds now.
@gmarin13 gmarin13 requested a review from s-kanev October 17, 2024 19:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.95%. Comparing base (0ed6a68) to head (a28ad78).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   66.86%   66.95%   +0.09%     
==========================================
  Files          44       44              
  Lines        9824     9857      +33     
==========================================
+ Hits         6569     6600      +31     
- Misses       2794     2817      +23     
+ Partials      461      440      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmarin13 gmarin13 merged commit 017d972 into google:main Oct 17, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants