-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add show_from profile filter. #372
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0776b46
moved the showFrom filter from branch filter2 to branch filters3. It …
lvng 331aae2
added show_from command line flag and driver test.
lvng 75fee66
added show_from handling to command overrides to avoid applying it fo…
lvng 30bb8e2
review feedback round 1.
lvng 35a7878
Merge branch 'master' into filters3
aalexand 5e56ca2
review feedback round 2.
lvng 271c8f3
Merge branch 'filters3' of github.com:lvng/pprof into filters3
lvng df73391
Merge branch 'master' into filters3
aalexand 7af823d
Add show_from to pprof doc.
lvng 397e732
Merge branch 'filters3' of github.com:lvng/pprof into filters3
lvng 2e80e4e
change language of show_from doc.
lvng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
internal/driver/testdata/pprof.cpu.cum.lines.tree.show_from
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
Active filters: | ||
show_from=line2 | ||
Showing nodes accounting for 1.01s, 90.18% of 1.12s total | ||
----------------------------------------------------------+------------- | ||
flat flat% sum% cum cum% calls calls% + context | ||
----------------------------------------------------------+------------- | ||
0 0% 0% 1.01s 90.18% | line2000 testdata/file2000.src:4 | ||
1.01s 100% | line2001 testdata/file2000.src:9 (inline) | ||
----------------------------------------------------------+------------- | ||
1.01s 100% | line2000 testdata/file2000.src:4 (inline) | ||
0.01s 0.89% 0.89% 1.01s 90.18% | line2001 testdata/file2000.src:9 | ||
1s 99.01% | line1000 testdata/file1000.src:1 | ||
----------------------------------------------------------+------------- | ||
1s 100% | line2001 testdata/file2000.src:9 | ||
1s 89.29% 90.18% 1s 89.29% | line1000 testdata/file1000.src:1 | ||
----------------------------------------------------------+------------- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have test cases that check that "show from" shows frames from the highest match? It is not obvious from the test names that any test does that. Need a test for both locations and lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added two test cases. one for matching multiple frames without inlines, and one with inlines.