Fake mappings should be merged into a single one during merging #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexand
reviewed
Apr 6, 2018
profile/merge.go
Outdated
| m.File, | ||
| switch { | ||
| case m.BuildID != "": | ||
| key.buildidIDOrFile = m.BuildID |
There was a problem hiding this comment.
buildidIDOrFile -> buildIDOrFile?
There was a problem hiding this comment.
Fixed. Not sure if buildidIDOrFile was intentional, but buildIDOrFile sounds enough.
aalexand
reviewed
Apr 6, 2018
profile/merge_test.go
Outdated
| @@ -0,0 +1,167 @@ | |||
| // Copyright 2014 Google Inc. All Rights Reserved. | |||
aalexand
reviewed
Apr 6, 2018
| "testing" | ||
| ) | ||
|
|
||
| func TestMapMapping(t *testing.T) { |
There was a problem hiding this comment.
Please confirm the test fails before the fix.
There was a problem hiding this comment.
Yes, TestMapMapping/same_fake_mapping fails before the change.
aalexand
previously approved these changes
Apr 6, 2018
|
I'll merge once CI finishes. |
|
@jqll CI fails, PTAL. |
aalexand
approved these changes
Apr 6, 2018
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
==========================================
+ Coverage 66.48% 66.54% +0.05%
==========================================
Files 36 36
Lines 7454 7446 -8
==========================================
- Hits 4956 4955 -1
+ Misses 2094 2089 -5
+ Partials 404 402 -2
Continue to review full report at Codecov.
|
KISSMonX
pushed a commit
to KISSMonX/pprof
that referenced
this pull request
Jun 14, 2018
* 'master' of github.com:google/pprof: (32 commits) record diff base profile label key/value constant (google#384) apply additional command overrides based on report format (google#381) profile: fix legacy format Go heap profile parsing (google#382) add -diff flag for better profile comparision (google#369) Use -u flag in pprof installation command so that it updates if needed. (google#376) Add GetBase support for ASLR kernel mappings (google#371) Add show_from profile filter. (google#372) Update README.md due to 8dff45d (google#375) Remove stale docs, move useful ones. (google#374) internal/driver: skip tests requiring tcp on js (google#373) Add "trim path" option which can be used to relocate sources. (google#366) Move update_d3flamegraph.sh script from the root directory. (google#370) Skip unsymbolizable mapping during symbolz pass. (google#368) remove -positive_percentages flag (google#365) Render icicle graph in "Flame Graph" view (google#367) Add command-line editing support for interactive pprof (google#362) Improve profile filter unit tests, fix show filtering of mappings (google#354) Fake mappings should be merged into a single one during merging (google#357) Hack the code so that both existing Go versions and current Go master format it the same (google#358) moved filter tests into their own test file which matches the implementation file, filter.go. (google#356) ...
gmarin13
pushed a commit
to gmarin13/pprof
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.