Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use goroutine profile in TestHttpsInsecure. #350

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

aalexand
Copy link
Collaborator

Trying to test against /debug/pprof/profile has been giving some flakes
and trouble so far (#146, #253, #328, golang/go#24611, golang/go#22594). While
some of the discussions the failures triggered appear to be useful (such
as whether CPU profiles are expected to be working on Windows XP or
not), that kind of testing is not really in the scope for this
particular test. This change switches the test to use goroutine profile
instead which is hopefully much less dependent on the environment. The
change also makes the test much faster to run.

Tested:

$ cd internal/driver/
$ go test -c
$ taskset -c 0 stress -p 16 ./driver.test -test.v
17 runs so far, 0 failures
48 runs so far, 0 failures
76 runs so far, 0 failures
101 runs so far, 0 failures
128 runs so far, 0 failures
158 runs so far, 0 failures
184 runs so far, 0 failures
210 runs so far, 0 failures
239 runs so far, 0 failures
^C

Before the change the command would produce failing runs shortly after its start.

Trying to test against /debug/pprof/profile has been giving some flakes
and trouble so far (google#146, google#253, google#328, golang/go#24611, golang/go#22594). While
some of the discussions the failures triggered appear to be useful (such
as whether CPU profiles are expected to be working on Windows XP or
not), that kind of testing is not really in the scope for this
particular test. This change switches the test to use goroutine profile
instead which is hopefully much less dependent on the environment. The
change also makes the test much faster to run.
@codecov-io
Copy link

codecov-io commented Mar 31, 2018

Codecov Report

Merging #350 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files          36       36           
  Lines        7441     7441           
=======================================
  Hits         4950     4950           
  Misses       2087     2087           
  Partials      404      404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6084089...75eb1f8. Read the comment docs.

@aalexand aalexand requested a review from nolanmar511 April 1, 2018 02:05
@nolanmar511 nolanmar511 merged commit 36d5638 into google:master Apr 2, 2018
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
Trying to test against /debug/pprof/profile has been giving some flakes
and trouble so far (google#146, google#253, google#328, golang/go#24611, golang/go#22594). While
some of the discussions the failures triggered appear to be useful (such
as whether CPU profiles are expected to be working on Windows XP or
not), that kind of testing is not really in the scope for this
particular test. This change switches the test to use goroutine profile
instead which is hopefully much less dependent on the environment. The
change also makes the test much faster to run.
@aalexand aalexand deleted the deflake-https-insecure-test branch January 11, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants