Add tagshow/taghide commands to select a subset of tags in a profile #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // FilterTagsByName filters the tags in a profile and only keeps | ||
| // tags that match show and not hide. | ||
| func (p *Profile) FilterTagsByName(show, hide *regexp.Regexp) (sm, hm bool) { | ||
| matchShow := func(name string) bool { |
There was a problem hiding this comment.
It is a bit difficult to read code with two matchShow variables with different meanings next to each other.
Maybe in this case, I would choose matchRemove for the function, then return !matchShow || matchHide and change later 2x if matchRemove(lab) { ... } so there are less negations to think in.
lannadorai
pushed a commit
to lannadorai/pprof
that referenced
this pull request
Mar 1, 2018
* Add dependency on googlemock to enable EXPECT_THAT(<container>, Contains(...)); This should allow simplified tests that are more readable and easier to add. (also clean up an attempt to LOG() a streamstream that failed to compile.) PiperOrigin-RevId: 174061634 * Store perf-version in profile.proto comment. PiperOrigin-RevId: 174094448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.