Skip TestWebInterface on nacl #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not see #235 changing TestWebInterface, am I missing something? |
|
Sorry -- made mistake in typing the PR. #229 |
aalexand
approved these changes
Nov 1, 2017
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 65.38% 65.46% +0.08%
==========================================
Files 34 34
Lines 7173 7173
==========================================
+ Hits 4690 4696 +6
+ Misses 2088 2082 -6
Partials 395 395
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #251.
In #229, TestWebInterface was modified the server, so it now runs in a separate thread.
I think that this changes how tests interact with the server, so it runs into limitations similar to those which caused #196 (specifically that tcp isn't available on nacl).