Do not attempt to open the browser in tests. (#259)

google · Nov 10, 2017 · e82ee9a · e82ee9a
1 parent 9e20b5b
commit e82ee9a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/internal/driver/driver.go b/internal/driver/driver.go
@@ -54,7 +54,7 @@ func PProf(eo *plugin.Options) error {
 	}
 
 	if src.HTTPHostport != "" {
-		return serveWebInterface(src.HTTPHostport, p, o)
+		return serveWebInterface(src.HTTPHostport, p, o, true)
 	}
 	return interactive(p, o)
 }

diff --git a/internal/driver/webui.go b/internal/driver/webui.go
@@ -81,7 +81,7 @@ type webArgs struct {
 	Top      []report.TextItem
 }
 
-func serveWebInterface(hostport string, p *profile.Profile, o *plugin.Options) error {
+func serveWebInterface(hostport string, p *profile.Profile, o *plugin.Options, wantBrowser bool) error {
 	host, portStr, err := net.SplitHostPort(hostport)
 	if err != nil {
 		return fmt.Errorf("could not split http address: %v", err)
@@ -123,7 +123,9 @@ func serveWebInterface(hostport string, p *profile.Profile, o *plugin.Options) e
 		},
 	}
 
-	go openBrowser("http://"+args.Hostport, o)
+	if wantBrowser {
+		go openBrowser("http://"+args.Hostport, o)
+	}
 	return server(args)
 }
 

diff --git a/internal/driver/webui_test.go b/internal/driver/webui_test.go
@@ -57,7 +57,7 @@ func TestWebInterface(t *testing.T) {
 		Obj:        fakeObjTool{},
 		UI:         &stdUI{},
 		HTTPServer: creator,
-	})
+	}, false)
 	<-serverCreated
 	defer server.Close()