pw_digital_io: [[nodiscard]] on as() conversion functions

Also remove the "under construction" warning from the docs. Change-Id: If198f8975287a7a2ffe8478f45067c43e5308b1b Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/189815 Commit-Queue: Auto-Submit <[email protected]> Reviewed-by: Ted Pudlik <[email protected]> Presubmit-Verified: CQ Bot Account <[email protected]> Pigweed-Auto-Submit: Wyatt Hepler <[email protected]>
google · Feb 3, 2024 · a05ea16 · a05ea16
1 parent c5018fb
commit a05ea16
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/pw_digital_io/docs.rst b/pw_digital_io/docs.rst
@@ -5,9 +5,6 @@
 =============
 pw_digital_io
 =============
-.. warning::
-   This module is under construction and may not be ready for use.
-
 ``pw_digital_io`` provides a set of interfaces for using General Purpose Input
 and Output (GPIO) lines for simple Digital I/O. This module can either be used
 directly by the application code or wrapped in a device driver for more complex

diff --git a/pw_digital_io/public/pw_digital_io/internal/conversions.h b/pw_digital_io/public/pw_digital_io/internal/conversions.h
@@ -81,12 +81,12 @@ class Conversions {
   }
 
   template <typename T, typename = Enabled<T>>
-  constexpr T& as() {
+  [[nodiscard]] constexpr T& as() {
     return pw::internal::SiblingCast<T&, CommonBase>(static_cast<Self&>(*this));
   }
 
   template <typename T, typename = Enabled<T>>
-  constexpr const T& as() const {
+  [[nodiscard]] constexpr const T& as() const {
     return static_cast<const T&>(
         pw::internal::SiblingCast<const T&, CommonBase>(
             static_cast<const Self&>(*this)));