pw_rpc: Debug logs for call termination

Change-Id: I0ae9cff6f28f81d66866495ac9fde77a89312113 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/250152 Pigweed-Auto-Submit: Wyatt Hepler <[email protected]> Lint: Lint 🤖 <[email protected]> Reviewed-by: Ronan Chauvin <[email protected]> Presubmit-Verified: CQ Bot Account <[email protected]> Docs-Not-Needed: Wyatt Hepler <[email protected]> Reviewed-by: Alexei Frolov <[email protected]> Commit-Queue: Auto-Submit <[email protected]>
google · Dec 2, 2024 · 74663b2 · 74663b2
1 parent eb762ca
commit 74663b2
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/pw_rpc/client.cc b/pw_rpc/client.cc
@@ -62,6 +62,12 @@ Status Client::ProcessPacket(ConstByteSpan data) {
 
   switch (packet.type()) {
     case PacketType::RESPONSE:
+      PW_LOG_DEBUG("Client call %u for %u:%08x/%08x completed with status %s",
+                   static_cast<unsigned>(packet.call_id()),
+                   static_cast<unsigned>(packet.channel_id()),
+                   static_cast<unsigned>(packet.service_id()),
+                   static_cast<unsigned>(packet.method_id()),
+                   packet.status().str());
       // RPCs without a server stream include a payload with the final packet.
       if (call->has_server_stream()) {
         static_cast<internal::StreamResponseClientCall&>(*call).HandleCompleted(
@@ -72,6 +78,12 @@ Status Client::ProcessPacket(ConstByteSpan data) {
       }
       break;
     case PacketType::SERVER_ERROR:
+      PW_LOG_DEBUG("Client call %u for %u:%08x/%08x terminated with error %s",
+                   static_cast<unsigned>(packet.call_id()),
+                   static_cast<unsigned>(packet.channel_id()),
+                   static_cast<unsigned>(packet.service_id()),
+                   static_cast<unsigned>(packet.method_id()),
+                   packet.status().str());
       call->HandleError(packet.status());
       break;
     case PacketType::SERVER_STREAM:

diff --git a/pw_rpc/server.cc b/pw_rpc/server.cc
@@ -92,6 +92,12 @@ Status Server::ProcessPacket(internal::Packet packet) {
       break;
     case PacketType::CLIENT_ERROR:
       if (call != calls_end()) {
+        PW_LOG_DEBUG("Server call %u for %u:%08x/%08x terminated with error %s",
+                     static_cast<unsigned>(packet.call_id()),
+                     static_cast<unsigned>(packet.channel_id()),
+                     static_cast<unsigned>(packet.service_id()),
+                     static_cast<unsigned>(packet.method_id()),
+                     packet.status().str());
         call->HandleError(packet.status());
       } else {
         internal::rpc_lock().unlock();