Skip to content

Commit

Permalink
pw_toolchain_bazel: Explicitly depend on rules_cc
Browse files Browse the repository at this point in the history
pw_toolchain_bazel has explicit dependencies on things in rules_cc, this
change ensures that dependency is expressed in the MODULE.bazel and in
Pigweed's WORKSPACE.

Change-Id: Ie47b0617ad453c6f451fd1fd74a4478e205528cf
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/191430
Pigweed-Auto-Submit: Armando Montanez <[email protected]>
Reviewed-by: Keir Mierle <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
Reviewed-by: Matt Stark <[email protected]>
Presubmit-Verified: CQ Bot Account <[email protected]>
  • Loading branch information
armandomontanez authored and CQ Bot Account committed Feb 12, 2024
1 parent efa7618 commit 460f429
Show file tree
Hide file tree
Showing 3 changed files with 78 additions and 64 deletions.
7 changes: 7 additions & 0 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ http_archive(
],
)

http_archive(
name = "rules_cc",
sha256 = "2037875b9a4456dce4a79d112a8ae885bbc4aad968e6587dca6e64f3a0900cdf",
strip_prefix = "rules_cc-0.0.9",
urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.9/rules_cc-0.0.9.tar.gz"],
)

local_repository(
name = "pw_toolchain",
path = "pw_toolchain_bazel",
Expand Down
6 changes: 6 additions & 0 deletions pw_toolchain_bazel/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@ module(
name = "pw_toolchain",
version = "0.1",
)

# Note: rules_cc is special-cased repository; a dependency on rules_cc in a
# module will not ensure that the root Bazel module has that same version of
# rules_cc. For that reason, this primarily acts as a FYI. You'll still need
# to explicitly list this dependency in your own project's MODULE.bazel file.
bazel_dep(name = "rules_cc", version = "0.0.9")
129 changes: 65 additions & 64 deletions pw_toolchain_bazel/MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 460f429

Please sign in to comment.