Merge "[ui] Fix anchor overlap" into main

google · Sep 30, 2024 · b4b75ee · b4b75ee
2 parents fc5bb9d + 97a53a9
commit b4b75ee
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/...screenshots/chrome_rendering_desktop.test.ts/slice-with-flows/slice-with-flows.png.sha256 b/...screenshots/chrome_rendering_desktop.test.ts/slice-with-flows/slice-with-flows.png.sha256
@@ -1 +1 @@
-93a74d2983230b09da323b32f4f51f717b0c64b02ddf1d62c12091409248e5fe
+098ee0afd6595fa48d2bd70fa0cca88f094f10991dd799b935f4ae123697e5c7
diff --git a/test/data/ui-screenshots/sql_table_tab.test.ts/ShowTable-command/slices-table.png.sha256 b/test/data/ui-screenshots/sql_table_tab.test.ts/ShowTable-command/slices-table.png.sha256
@@ -1 +1 @@
-276cfd8d58f19fdc543e01e79042c021d0f7e338822c106e7063c5118ccf6bb0
+262c4822343595973f46b74e78ed9b8e77a2a4e1f7d59bffa3c5a1531bc7d140
diff --git a/...-screenshots/sql_table_tab.test.ts/slices-with-same-name/slices-with-same-name.png.sha256 b/...-screenshots/sql_table_tab.test.ts/slices-with-same-name/slices-with-same-name.png.sha256
@@ -1 +1 @@
-0d1b850b2e4a3fe71efb0be679d732bd397a3ab95145d8894d014e413e17ef14
+8d14a199592ccdaee19d43c36abd3c8e4465a1f028b1fa60e28683b91a76b9ce
diff --git a/ui/src/assets/widgets/anchor.scss b/ui/src/assets/widgets/anchor.scss
@@ -28,9 +28,7 @@
     background $pf-anim-timing;
 
   & > .material-icons {
-    // For some reason, floating this icon results in the most pleasing vertical
-    // alignment.
-    float: right;
+    vertical-align: bottom;
     margin: 0 0 0 0px;
     font-size: inherit;
     line-height: inherit;

diff --git a/ui/src/widgets/anchor.ts b/ui/src/widgets/anchor.ts
@@ -27,8 +27,8 @@ export class Anchor implements m.ClassComponent<AnchorAttrs> {
     return m(
       'a.pf-anchor',
       htmlAttrs,
-      icon && m('i.material-icons', icon),
       children,
+      icon && m('i.material-icons', icon),
     );
   }
 }
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		93a74d2983230b09da323b32f4f51f717b0c64b02ddf1d62c12091409248e5fe
		098ee0afd6595fa48d2bd70fa0cca88f094f10991dd799b935f4ae123697e5c7
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		276cfd8d58f19fdc543e01e79042c021d0f7e338822c106e7063c5118ccf6bb0
		262c4822343595973f46b74e78ed9b8e77a2a4e1f7d59bffa3c5a1531bc7d140
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		0d1b850b2e4a3fe71efb0be679d732bd397a3ab95145d8894d014e413e17ef14
		8d14a199592ccdaee19d43c36abd3c8e4465a1f028b1fa60e28683b91a76b9ce