Merge "Fix use after move" into main

google · Sep 9, 2024 · 9c4badd · 9c4badd
2 parents 1898fc7 + c18035d
commit 9c4badd
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/trace_processor/importers/perf/perf_data_tokenizer.cc b/src/trace_processor/importers/perf/perf_data_tokenizer.cc
@@ -260,8 +260,8 @@ PerfDataTokenizer::ParseRecords() {
         !res.ok() || *res != ParsingResult::kSuccess) {
       return res;
     }
-
-    switch (record.header.type) {
+    const uint32_t type = record.header.type;
+    switch (type) {
       case PERF_RECORD_AUXTRACE:
         PERFETTO_CHECK(!current_auxtrace_.has_value());
         current_auxtrace_.emplace();
@@ -279,8 +279,8 @@ PerfDataTokenizer::ParseRecords() {
 
       default:
         if (!PushRecord(std::move(record)).ok()) {
-          context_->storage->IncrementIndexedStats(
-              stats::perf_record_skipped, static_cast<int>(record.header.type));
+          context_->storage->IncrementIndexedStats(stats::perf_record_skipped,
+                                                   static_cast<int>(type));
         }
         break;
     }