Skip to content

Commit

Permalink
ui: Remove unused track-decider related types from various plugins
Browse files Browse the repository at this point in the history
Several types were defined and exported but never used.

Some of the interfaces these types depend on (`AddTrackArgs`) are going
away soon, so this CL just removes the unused types.

Change-Id: I34ebf54bc5733591a8dc4e74be79fc3a083d0795
  • Loading branch information
stevegolton committed Aug 23, 2024
1 parent 247bcf7 commit 7b927e1
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 17 deletions.
5 changes: 0 additions & 5 deletions ui/src/core_plugins/chrome_scroll_jank/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import {AddTrackArgs} from '../../common/actions';
import {ObjectByKey} from '../../common/state';
import {featureFlags} from '../../core/feature_flags';
import {CustomSqlDetailsPanelConfig} from '../../frontend/tracks/custom_sql_table_slice_track';
Expand All @@ -24,10 +23,6 @@ export const ENABLE_CHROME_SCROLL_JANK_PLUGIN = featureFlags.register({
defaultValue: false,
});

export type DecideTracksResult = {
tracksToAdd: AddTrackArgs[];
};

export interface ScrollJankTrackSpec {
key: string;
sqlTableName: string;
Expand Down
8 changes: 1 addition & 7 deletions ui/src/core_plugins/chrome_scroll_jank/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import {v4 as uuidv4} from 'uuid';

import {uuidv4Sql} from '../../base/uuid';
import {DeferredAction} from '../../common/actions';
import {generateSqlWithInternalLayout} from '../../common/internal_layout_utils';
import {featureFlags} from '../../core/feature_flags';
import {GenericSliceDetailsTabConfig} from '../../frontend/generic_slice_details_tab';
Expand All @@ -33,7 +32,7 @@ import {
import {Engine} from '../../trace_processor/engine';

import {ChromeTasksScrollJankTrack} from './chrome_tasks_scroll_jank_track';
import {DecideTracksResult, ENABLE_CHROME_SCROLL_JANK_PLUGIN} from './common';
import {ENABLE_CHROME_SCROLL_JANK_PLUGIN} from './common';
import {EventLatencySliceDetailsPanel} from './event_latency_details_panel';
import {EventLatencyTrack, JANKY_LATENCY_NAME} from './event_latency_track';
import {ScrollDetailsPanel} from './scroll_details_panel';
Expand All @@ -49,11 +48,6 @@ const ENABLE_SCROLL_JANK_PLUGIN_V2 = featureFlags.register({
defaultValue: false,
});

export type ScrollJankTrackGroup = {
tracks: DecideTracksResult;
addTrackGroup: DeferredAction;
};

class ChromeScrollJankPlugin implements PerfettoPlugin {
async onTraceLoad(ctx: PluginContextTrace): Promise<void> {
if (ENABLE_CHROME_SCROLL_JANK_PLUGIN.get()) {
Expand Down
5 changes: 0 additions & 5 deletions ui/src/core_plugins/screenshots/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
// limitations under the License.

import {uuidv4} from '../../base/uuid';
import {AddTrackArgs} from '../../common/actions';
import {GenericSliceDetailsTabConfig} from '../../frontend/generic_slice_details_tab';
import {
BottomTabToSCSAdapter,
Expand All @@ -26,10 +25,6 @@ import {
import {ScreenshotTab} from './screenshot_panel';
import {ScreenshotsTrack} from './screenshots_track';

export type DecideTracksResult = {
tracksToAdd: AddTrackArgs[];
};

class ScreenshotsPlugin implements PerfettoPlugin {
async onTraceLoad(ctx: PluginContextTrace): Promise<void> {
const res = await ctx.engine.query(`
Expand Down

0 comments on commit 7b927e1

Please sign in to comment.