Skip to content

Commit

Permalink
Modify trace redactor target to be included in module apex
Browse files Browse the repository at this point in the history
Trace redactor needs to live in the apex so that it can be updated with it.

As a first step, prepare the target by:
- Adding apex available
- Setting a min sdk to match the apex

Test: presubmit, tested with future changes to make sure it can be added to apex
Bug: 379255273
Flag: EXEMPT - infeasible
Change-Id: Ie178f89a5dc69585b01095f553cebca78605f3a8
  • Loading branch information
Yisroel Forta committed Nov 15, 2024
1 parent 6cdc068 commit 1554c9d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -17078,6 +17078,11 @@ cc_binary {
cflags: [
"-DZLIB_IMPLEMENTATION",
],
apex_available: [
"//apex_available:platform",
"com.android.profiling",
],
min_sdk_version: "35",
}

// GN: //src/traceconv:traceconv
Expand Down
7 changes: 7 additions & 0 deletions tools/gen_android_bp
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,13 @@ additional_args = {
],
'libperfetto': [('export_include_dirs', {'include', buildflags_dir}),],
'perfetto': [('required', {'perfetto_persistent_cfg.pbtxt'}),],
'trace_redactor': [
('min_sdk_version', '35'),
('apex_available', {
'//apex_available:platform',
'com.android.profiling'
}),
],
}


Expand Down

0 comments on commit 1554c9d

Please sign in to comment.