Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packetdrill: fix compilation/runtime error for linux 3.x #34

Closed
wants to merge 1 commit into from
Closed

packetdrill: fix compilation/runtime error for linux 3.x #34

wants to merge 1 commit into from

Commits on Feb 18, 2020

  1. packetdrill: fix compilation/runtime error for linux 3.x 

    For linux 3.10, TCP_CC_INFO and SO_MEMINFO are not supported. When we
define HAVE_SO_MEMINFO / HAVE_TCP_CC_INFO as 0, functions like
write_tcp_bbr_cc_info and write_so_meminfo will not be accessed. So
wrap them with #ifdef and #endif.

Also, for lower linux version, tcp_info option value has less
fields(e.g. 120 bytes). So remove the size assert.

This commit is based on the following packetdrill upstream pull
request, with a slightly tweaked commit description:
  google#13

Signed-off-by: Neal Cardwell <[email protected]>
Change-Id: I2f4f8cea7357356f2041eabed044b6f7616d4e91
    @nealcardwell
    Shu Ma authored and nealcardwell committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    bb4bc0b View commit details
    Browse the repository at this point in the history