-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align GoVulncheck Go version with go.mod #818
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
===========================================
- Coverage 71.79% 59.46% -12.33%
===========================================
Files 118 136 +18
Lines 8677 11162 +2485
===========================================
+ Hits 6230 6638 +408
- Misses 2078 4099 +2021
- Partials 369 425 +56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test we can add for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: Rex P <[email protected]>
see google/osv-scanner#818 for details Signed-off-by: Spencer Schrock <[email protected]>
GoVulncheck uses local installed GO version to determine vulnerabilities if the env
GOVERSION
is not defined.Set the
GOVERSION
value to the one defined in go.mod.detail: #679