Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update workflows to v4 (major) #784

Merged
merged 1 commit into from
Feb 29, 2024
Merged

chore(deps): update workflows to v4 (major) #784

merged 1 commit into from
Feb 29, 2024

Conversation

renovate-bot
Copy link
Collaborator

@renovate-bot renovate-bot commented Feb 4, 2024 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Type Update Change
codecov/codecov-action action major v3.1.6 -> v4.1.0
golangci/golangci-lint-action action major v3.7.1 -> v4.0.0

Release Notes

codecov/codecov-action (codecov/codecov-action)

v4.1.0

Compare Source

v4.0.2

Compare Source

What's Changed
New Contributors

Full Changelog: codecov/codecov-action@v4.0.1...v4.0.2

v4.0.1

Compare Source

What's Changed

Full Changelog: codecov/codecov-action@v4.0.0...v4.0.1

v4.0.0

Compare Source

v4 of the Codecov Action uses the CLI as the underlying upload. The CLI has helped to power new features including local upload, the global upload token, and new upcoming features.

Breaking Changes
  • The Codecov Action runs as a node20 action due to node16 deprecation. See this post from GitHub on how to migrate.
  • Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token). This doc shows instructions on how to add the Codecov token.
  • OS platforms have been added, though some may not be automatically detected. To see a list of platforms, see our CLI download page
  • Various arguments to the Action have been changed. Please be aware that the arguments match with the CLI's needs

v3 versions and below will not have access to CLI features (e.g. global upload token, ATS).

What's Changed
New Contributors

Full Changelog: codecov/codecov-action@v3.1.6...v4.0.0

golangci/golangci-lint-action (golangci/golangci-lint-action)

v4.0.0

Compare Source

What's Changed

Documentation
Dependencies

Configuration

📅 Schedule: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Feb 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.41%. Comparing base (ba20bfd) to head (6a3808f).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   59.51%   59.41%   -0.10%     
==========================================
  Files         136      136              
  Lines       11142    11142              
==========================================
- Hits         6631     6620      -11     
- Misses       4088     4099      +11     
  Partials      423      423

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate-bot renovate-bot force-pushed the renovate/major-workflows branch 2 times, most recently from 8e44529 to 2f009f1 Compare February 9, 2024 16:49
@renovate-bot renovate-bot changed the title chore(deps): update codecov/codecov-action action to v4 chore(deps): update workflows to v4 (major) Feb 9, 2024
@hogo6002 hogo6002 merged commit 72eae2f into google:main Feb 29, 2024
11 checks passed
@renovate-bot renovate-bot deleted the renovate/major-workflows branch March 12, 2024 09:50
@G-Rath G-Rath mentioned this pull request Mar 19, 2024
Merged
another-rex pushed a commit that referenced this pull request Mar 19, 2024
@G-Rath
ci: downgrade codecov action to v3 (#871)
a90d443 
It seems that v4 is having some teething problems - coverage is no
longer being uploaded due to the lack of a token, and it seems like at
least some people are getting 500s even when they do provide a token
(codecov/codecov-action#1248).

Let's start by downgrading to a known working version, and go from
there.

Relates to #784

Before: 

<img width="1009" alt="image"
src="https://github.com/google/osv-scanner/assets/3151613/24e6556f-0c94-4c4a-9269-cd59188f303f">

After:

<img width="1334" alt="image"
src="https://github.com/google/osv-scanner/assets/3151613/3e5bd689-0daf-410e-814c-62facf3ef50c">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@another-rex another-rex another-rex approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@renovate-bot @codecov-commenter @another-rex @hogo6002