ci: run tests on Windows #553
Conversation
Codecov Report
@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 78.73% 78.69% -0.05%
==========================================
Files 79 80 +1
Lines 5742 5782 +40
==========================================
+ Hits 4521 4550 +29
- Misses 1033 1043 +10
- Partials 188 189 +1
|
G-Rath
changed the title
|
I think I fixed the (first) govulncheck problem with 734094c, the error it revealed I have to guess is because of line endings (I'm not sure why the line endings would change, but the +12 differences matches up with the line number/num of new lines). I think we just have to have two different test values for different platforms? |
|
Oh I know why it has windows line endings, it's the same reason the SARIF test is failing, the github action git checkout is configured to automatically change line endings to the windows version when checking out on windows, just configuring it to not do that will fix both the SARIF error and the govulncheck test error |
I don't think doing that is the end of the world, but also is this something Go should actually be handling 🤔 I've inlined |
Cherry-picked from #553 --- It's required for testing against Windows because it has a different error message, but it's also just a good overall change and landing it separately removes ~25 files from the main PR 😅
This reverts commit fcaba89.
Turns out that file -> url translation on Windows is busted, and that this is a hard problem that Go has an internal util for that has not yet been made public - I've done what apparently a number of other packages have done which is copying that helper into here and hoping one day it actually becomes public 😢 Note that until #646 is landed, there is no way to actually verify this is fixing the problem - #553 shows the result of both PRs being merged.
Unsurprisingly this has required a bunch of tests to be updated to handle slightly different variations in file path handling - this eventually resulted in me implementing an actual internal snapshot testing package but I've not included that in here since its sizable on its own; so please keep that in mind when reviewing . (see https://github.com/G-Rath/osv-scanner/commit/1273da79e2e26a18d663da482dc5f09258e15c51 for a sneakpeek on what the snapshot-based testing looks like) ~Note that is failing because file -> url path translation is actually busted; I've opened #645 to fix this and you can see the passing CI when both of these changes are merged in #553~ Resolves #603 Resolves #553
Resolves #603