Rust call analysis #452
Rust call analysis #452
Conversation
| func cleanRustFunctionSymbols(val string) string { | ||
| // Used to remove generics from functions and types as they are not included in function calls | ||
| // in advisories: | ||
| // E.g.: `smallvec::SmallVec<A>::new` => `smallvec::SmallVec::new` |
There was a problem hiding this comment.
I wonder if we should start a discussion here if the data can be formatted in a more convenient way to begin with?
Regex seems potentially very error prone here.
another-rex
force-pushed
the
rust-call-graph
branch
from
d8742f1
to
b490584
Compare
docs/output.md
Outdated
| ``` | ||
|
|
||
| **Rendered:** | ||
|
|
||
| | OSV URL | CVSS | Ecosystem | Package | Version | Source | |
There was a problem hiding this comment.
So when I saw that there were changes in the output file, I was hoping to see output from the SCAs. How does the Go & Rust output look different from the standard ?
There was a problem hiding this comment.
Added some examples and JSON comments explaining the output more thoroughly.
There was a problem hiding this comment.
LGTM!
As discussed offline, let's raise some data formatting (re the remaining open comment on the PR around generics) and consistency issues (e.g. macros) with the upstream RustSec folks. It would be nice to show osv-scanner as an example tool that can leverage the DB to its full extent.
Support rust for call analysis, the current version is fully working for any rust binary or library that can be built with
cargo buildPart of #476
TODO:
Limitations: #464