Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update spdx license ids #1310

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Oct 8, 2024

While working on #1309 I learned that this list is out of date, so this regenerates it - I don't think it's a big deal, but I've also made a local note to look into potentially automating this more (it probably ideally should happen before every release)

@G-Rath G-Rath changed the title fix: generate spdx license ids fix: update spdx license ids Oct 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.47%. Comparing base (2f87877) to head (847f678).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
- Coverage   68.47%   68.47%   -0.01%     
==========================================
  Files         175      175              
  Lines       16832    16832              
==========================================
- Hits        11526    11525       -1     
- Misses       4679     4680       +1     
  Partials      627      627              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath G-Rath added the bug Something isn't working label Oct 8, 2024
Copy link
Contributor

@cuixq cuixq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - shall we set up some regular process to regenerate the file regularly?

@G-Rath
Copy link
Collaborator Author

G-Rath commented Oct 8, 2024

shall we set up some regular process to regenerate the file regularly?

Yup I plan(ned) to look into this as a follow-up - I don't think it's super critical given how few new licenses there are on the whole and that no one has opened an issue (that I know of) about a license being missing, but I ended up doing #1312 which I think is a good starting improvement.

Since I don't do the releases, I'd have to defer to others on what would be sufficient enough beyond that workflow change - but I'm happy to do the work once someone tells me what should be done 🙂

@cuixq
Copy link
Contributor

cuixq commented Oct 9, 2024

I think it's a good idea to add an extra step to our release process to generate all the files. maybe make a script so that we can run it to regenerate everything?

@cuixq cuixq merged commit 43f9526 into google:main Oct 9, 2024
15 checks passed
@cuixq cuixq deleted the fix/regenerate-licenses branch October 9, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants