fix: warn about and ignore duplicate entries in SBOMs #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
==========================================
- Coverage 68.47% 68.47% -0.01%
==========================================
Files 175 175
Lines 16832 16840 +8
==========================================
+ Hits 11526 11531 +5
- Misses 4679 4681 +2
- Partials 627 628 +1 ☔ View full report in Codecov by Sentry. |
G-Rath
force-pushed
the
fix/deduplicate-sbom
branch
from
6ef98d6
to
d3ffb9e
Compare
G-Rath
force-pushed
the
fix/deduplicate-sbom
branch
from
d3ffb9e
to
e71475d
Compare
cuixq
reviewed
Oct 8, 2024
G-Rath
force-pushed
the
fix/deduplicate-sbom
branch
from
8b44954
to
91f61e0
Compare
G-Rath
force-pushed
the
fix/deduplicate-sbom
branch
from
91f61e0
to
b0ad3a3
Compare
cuixq
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While from what I understand duplicates should not be possible in a valid SBOM, apparently they happen and it's useful for us to report + skip them.
Since doing this efficiently requires use of a map we in turn have to sort the packages to ensure a consistent output order, leading to me discovering that we're not already sorting the packages - I've opened #1288 to land that change first.
Resolves #330