fix(offline): report all ecosystems without local databases in one single line #1279
Conversation
| @@ -641,6 +641,35 @@ func TestRun_LocalDatabases(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestRun_LocalDatabases_AlwaysOffline(t *testing.T) { | |||
There was a problem hiding this comment.
note: I've had to put this in a dedicated test because our other local db tests try to reuse the database as an optimization when run locally, which is exactly what we don't want here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
+ Coverage 68.37% 68.44% +0.06%
==========================================
Files 175 175
Lines 16786 16798 +12
==========================================
+ Hits 11478 11497 +19
+ Misses 4677 4672 -5
+ Partials 631 629 -2 ☔ View full report in Codecov by Sentry. |
| // the most likely error at this point is that the PURL could not be parsed | ||
| r.Errorf("could not load db for %s ecosystem: %v\n", pkg.Ecosystem, err) |
There was a problem hiding this comment.
note: this no longer has coverage, but that's fine
while my comment mentions a possible error being a PURL could not be parsed, we've not got a test for that and I'm not sure how easy it'll be - I've made a note to look into that as a separate thing, but we shouldn't let it block this as I think we want to be playing it safe i.e. by logging the error rather than assume the only possible error could be that the database cannot be found
G-Rath
force-pushed
the
improve-offline-errors
branch
from
edb00fb
to
c04e4c3
Compare
This reduces the amount of noise generated when using
--offlineif a database is not available for a particular ecosystem. While it was suggested that we could have some form of general error cache, for now I've just optimized for this specific case as really it's the one we expect the most and (in part) I think the nature of Go makes the more generic improvement a bit too faffy vs the gain.Resolves #1005