Skip to content

Commit

Permalink
ci: remove unneeded setup-go step and pin `actions/download-artifac…
Browse files Browse the repository at this point in the history
…t` (#786)

I was having a look at the openssf scorecard score as I've not really
dug into that before, and saw it was flagging some unpinned actions.

Most of them were about the `osv-scanner` action itself which I don't
think can be pinned since the point is to use the latest version for
self testing right? but we can pin `actions/download-artifact` and
`actions/setup-go` _though_ I'm pretty sure that isn't needed anymore
because it was a workaround for
github/codeql#13992 and we were just waiting
on a new version? either way we'll find out.
  • Loading branch information
G-Rath authored Mar 4, 2024
1 parent f7d28df commit 901f212
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
# Update go to the latest version to support minor go versions is go.mod file
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
with:
go-version-file: go.mod
# Initializes the CodeQL tools for scanning.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/osv-scanner-reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
with:
persist-credentials: false
- name: "Download custom artifact if specified"
uses: actions/download-artifact@v4
uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1
if: "${{ inputs.download-artifact != '' }}"
with:
name: "${{ inputs.download-artifact }}"
Expand Down

0 comments on commit 901f212

Please sign in to comment.