Make centipede a default fuzzer #9300

jonathanmetzman · 2022-12-28T18:16:42Z

Related: #9299

jonathanmetzman · 2023-02-07T04:27:23Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

jonathanmetzman · 2023-02-07T04:31:23Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

jonathanmetzman · 2023-02-07T04:32:29Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

jonathanmetzman · 2023-02-07T04:34:20Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

jonathanmetzman · 2023-02-07T04:36:59Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

jonathanmetzman · 2023-02-07T05:06:28Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

jonathanmetzman · 2023-02-07T16:29:32Z

Failures:
sound-open-firmware not using CXX
cyclonedds: not using CXX https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/c07b620e-6fbb-4281-808c-4c1716420f46;tab=detail?project=oss-fuzz
curl: not using CXX: https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/da3be731-25d8-415b-b7b8-e13dd3bd4598?project=oss-fuzz
cpython3: https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/e88b854c-f0d2-4abb-ab73-3f835e758ae8;tab=detail?project=oss-fuzz not linking in weak.o?
skia - cant compile none.
libtorrent - bad build check
ffmpeg - no space in bad build check
cfengine - error: expression is not an integer constant expression https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/e3d8566a-f7cd-40fc-930d-99639313be58?project=oss-fuzz

jonathanmetzman · 2023-02-07T16:37:20Z

suricata: https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/fd9648c4-bf0b-45e4-aeca-9e66852e9141;step=19?project=oss-fuzz
spdk: https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/5fca918f-8a65-4e48-9dbd-e0f1a9e09a7c;tab=detail?project=oss-fuzz

jonathanmetzman · 2023-02-07T16:46:41Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

jonathanmetzman · 2023-02-07T17:37:14Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

jonathanmetzman · 2023-02-07T20:04:49Z

not linking with CXX
wget
vlc
utf8proc
tpm2-tss
proftpd
opensips
opensc
netcdf
net-snmp
libpsl
fluent-bit
sound-open-firmware
curl
cyclonedds: not using CXX https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/c07b620e-6fbb-4281-808c-4c1716420f46;tab=detail?project=oss-fuzz

libtorrent: bad build
ffmpeg: no space

sed
poppler
lua
kimageformats
karchive
kcodecs

varnish: sub.c:96:6: error: implicit declaration of function 'closedir' is invalid in C99 [-Werror,-Wimplicit-function-declaration] https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/bc7a53f1-fd3b-4301-99c1-a7c4790eaf7e?project=oss-fuzz
pigweed - needs asan (asan centipede works)
nets-snmp https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/e67b2f63-e86d-44af-83f6-62a4d7cf5d72?project=oss-fuzz undefined reference to ceil
lxc

#23 - "build-check-centipede-none-x86_64": To reproduce, run:
Step #23 - "build-check-centipede-none-x86_64": Build checks failed.
Step #23 - "build-check-centipede-none-x86_64": ********************************************************************************
Step #23 - "build-check-centipede-none-x86_64": ERROR: 33.333333333333336% of fuzz targets seem to be broken. See the list above for a detailed information.
Step #23 - "build-check-centipede-none-x86_64": 
Step #23 - "build-check-centipede-none-x86_64": /usr/local/bin/run_fuzzer: line 225:  1234 Aborted                 bash -c "$CMD_LINE"
Step #23 - "build-check-centipede-none-x86_64": libc++abi: terminating with uncaught exception of type std::__1::__fs::filesystem::filesystem_error: filesystem error: in recursive_directory_iterator: No such file or directory ["/tmp/fuzz-lxc-flagfile-read_corpus"]
Step #23 - "build-check-centipede-none-x86_64": I0207 17:49:07.868296    1234 environment.cc:317] --timeout_per_batch default wasn't overridden; auto-computed to be 4616 sec (see --help for details)
Step #23 - "build-check-centipede-none-x86_64": I0207 17:49:07.868278    1234 config_file.cc:290] Command line was augmented; reparsing
Step #23 - "build-check-centipede-none-x86_64": new_arg=--binary=/tmp/not-out/tmprqrlzl7m/fuzz-lxc-flagfile-read 
Step #23 - "build-check-centipede-none-x86_64": old_arg=--binary=/tmp/not-out/tmprqrlzl7m/fuzz-lxc-config-read 
Step #23 - "build-check-centipede-none-x86_64": I0207 17:49:07.868274    1234 config_file.cc:137] Augmented argv arg:
Step #23 - "build-check-centipede-none-x86_64": new_arg=--corpus_dir=/tmp/fuzz-lxc-flagfile-read_corpus 
Step #23 - "build-check-centipede-none-x86_64": old_arg=--corpus_dir=/tmp/fuzz-lxc-config-read_corpus

https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/db4745ce-fc2a-41b2-9deb-2333ff5d39d8?project=oss-fuzz
ecc-diff-fuzzer https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/a20dca04-527b-426b-a31d-83265b497ad0;step=22?project=oss-fuzz rust
cras rust
cfengine expression is not an integer https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/e3d8566a-f7cd-40fc-930d-99639313be58?project=oss-fuzz

realloc undefined reference
suricata https://pantheon.corp.google.com/cloud-build/builds;region=us-central1/fd9648c4-bf0b-45e4-aeca-9e66852e9141?project=oss-fuzz
spdk

il-mem.c:(.text.SCReallocFunc[SCReallocFunc]+0x27): undefined reference to `rpl_realloc'
Step #19 - "compile-centipede-address-x86_64": /usr/bin/ld: libsuricata_c.a(util-mem.o): in function `SCReallocFunc':```

old image
php

jonathanmetzman · 2023-02-07T20:05:27Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

jonathanmetzman · 2023-02-07T21:52:51Z

I fixed the sed cases except for poppler

jonathanmetzman · 2023-02-07T21:54:19Z

/gcbrun trial_build.py lua kimageformats karchive kcodecs --sanitizer none address --fuzzing-engine centipede

jonathanmetzman · 2023-02-07T21:56:10Z

I think this is ready for review! I think most of the cases where I had to disable centipede will be too hard to fix in this round and that we can just land this for now.

jonathanmetzman · 2023-02-07T22:03:16Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

DonggeLiu

Thanks!

DonggeLiu · 2023-02-07T22:49:03Z

projects/cfengine/project.yaml

@@ -4,6 +4,10 @@ language: c++
 primary_contact: "[email protected]"
 auto_ccs:
  - "[email protected]"
+fuzzing_engines:


Is it OK to skip these?
I thought we will need to support Centipede eventually...

Another question:
I noticed that you disabled some projects, even though they build successfully in my PR (I highlighted them in the sheet, 537db38f is my build ID and 9b99ff13 is yours.)
I also tested curl on your branch locally, and found it can build and pass the bad_build_test.
Would you mind reminding me why they are disabled? Thanks!

Is it OK to skip these? I thought we will need to support Centipede eventually...

We don't need it now and we don't want build breakages now.

I noticed that you disabled some projects

Because they don't work without -lc++. I think we should consider adding that change at a later time.
There's about 10 projects that don't work without this, they are not doing what oss-fuzz asks and I'm not sure it's worth making a hack to support them. It might be better to force them to meet "our API" which requires using CXX to link.

I think it's probably going to be a long time before projects won't be able to use oss-fuzz unless they support centipede.

DonggeLiu · 2023-02-08T03:23:01Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

There is only one failure on openssl due to No space left.
Shall we disable it as well?

DonggeLiu · 2023-02-08T04:26:07Z

/gcbrun trial_build.py all --sanitizer none address --fuzzing-engine centipede

Related: #9299

Related: google#9299

jonathanmetzman mentioned this pull request Feb 7, 2023

Make Centipede a default engine #9427

Closed

2 tasks

jonathanmetzman force-pushed the centipede-default branch from bbcdce1 to 6fec78d Compare February 7, 2023 04:26

jonathanmetzman force-pushed the centipede-default branch from 6416192 to 6fec78d Compare February 7, 2023 04:32

jonathanmetzman marked this pull request as ready for review February 7, 2023 17:36

jonathanmetzman force-pushed the centipede-default branch from ef603dc to e4d19a3 Compare February 7, 2023 19:31

jonathanmetzman requested review from DonggeLiu and oliverchang February 7, 2023 21:54

DonggeLiu approved these changes Feb 7, 2023

View reviewed changes

jonathanmetzman added 4 commits February 8, 2023 11:19

Make centipede a default fuzzer

2286386

Related: #9299

fast test

2aa85ce

fix

5f7a91f

Fix

4ae740a

jonathanmetzman added 10 commits February 8, 2023 11:19

disable centipede for ffmpeg

a422abf

Fix skia build

455fa2b

Fix tests

847e536

disable wget

2c0ac0b

Disable broken

cde040d

disable

8879475

Disable

379457a

Fix sed cases

27b6bbe

fix project.yaml

2d322e2

Don't turn on centipede yet

088ec02

jonathanmetzman force-pushed the centipede-default branch from 7cff4f5 to 088ec02 Compare February 8, 2023 16:20

jonathanmetzman added 2 commits February 8, 2023 11:24

undo

f50e8d1

fix

07f248d

jonathanmetzman merged commit 2e6c7fa into master Feb 8, 2023

jonathanmetzman deleted the centipede-default branch February 8, 2023 16:28

evverx mentioned this pull request Mar 1, 2023

Projects using meson fail to compile with centipede #9431

Closed

eamonnmcmanus pushed a commit to eamonnmcmanus/oss-fuzz that referenced this pull request Mar 15, 2023

Opt-out of centipede in projects that don't support it (google#9300)

8fede50

Related: google#9299

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make centipede a default fuzzer #9300

Make centipede a default fuzzer #9300

jonathanmetzman commented Dec 28, 2022

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

DonggeLiu left a comment

DonggeLiu Feb 7, 2023

DonggeLiu Feb 8, 2023

jonathanmetzman Feb 8, 2023 •

edited

Loading

jonathanmetzman Feb 8, 2023

DonggeLiu commented Feb 8, 2023

DonggeLiu commented Feb 8, 2023

Make centipede a default fuzzer #9300

Make centipede a default fuzzer #9300

Conversation

jonathanmetzman commented Dec 28, 2022

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

jonathanmetzman commented Feb 7, 2023

DonggeLiu left a comment

Choose a reason for hiding this comment

DonggeLiu Feb 7, 2023

Choose a reason for hiding this comment

DonggeLiu Feb 8, 2023

Choose a reason for hiding this comment

jonathanmetzman Feb 8, 2023 • edited Loading

Choose a reason for hiding this comment

jonathanmetzman Feb 8, 2023

Choose a reason for hiding this comment

DonggeLiu commented Feb 8, 2023

DonggeLiu commented Feb 8, 2023

jonathanmetzman Feb 8, 2023 •

edited

Loading