Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-clang] Change OUR_LLVM_REVISION #6970

Merged
merged 2 commits into from
Dec 6, 2021
Merged

[base-clang] Change OUR_LLVM_REVISION #6970

merged 2 commits into from
Dec 6, 2021

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Dec 5, 2021

=llvmorg-14-init-11072-gb1bc627e corresponds to commit b1bc627e7e9965e6ec15e106ee4b2c21f6c36923, which includes commit 89eb85ac6eaab6431ef72ef705d560c72c5ed71f3 (the commit causing afl++ compile failures).

Thus, set it to llvmorg-14-init-8033-gabb2a91b, which compiles afl++ still fine.

For reference:

@maflcko
Copy link
Contributor Author

maflcko commented Dec 6, 2021

This fixes the build failures for us, and presumably everyone else, too.

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this locally and can verify AFL builds work following this.

@maflcko
Copy link
Contributor Author

maflcko commented Dec 6, 2021

can i haz merge plis

@DavidKorczynski
Copy link
Collaborator

CC @jonathanmetzman

@jonathanmetzman
Copy link
Contributor

Ouch. Thanks for doing this.

@jonathanmetzman
Copy link
Contributor

jonathanmetzman commented Dec 7, 2021

Very dumb of me to merge this when AFL was correctly failing in CI.

@jonathanmetzman
Copy link
Contributor

Very dumb of me to merge this when AFL was correctly failing in CI.

Nevermind, it was expected that it fails because it doesn't rebuild base-clang.

MartinPetkov pushed a commit to MartinPetkov/oss-fuzz that referenced this pull request Aug 15, 2022
* [base-clang] Change OUR_LLVM_REVISION

* llvmorg-14-init-8033-gabb2a91b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants