-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds bazel project opencensus-cpp #5533
Conversation
Yes, |
Nice! Thanks for taking care of this. |
@g-easy I would need one (or more) mail for you to get the report about bugs |
@jsuereth - what would you suggest re: email address? |
sorry for delay, was out for a bit. [email protected] would be ideal for us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment about the email
projects/opencensus-cpp/project.yaml
Outdated
@@ -0,0 +1,10 @@ | |||
homepage: "https://opencensus.io/" | |||
language: c++ | |||
primary_contact: "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the "+" breaks the auth for ClusterFuzz here, even if this was an email associated with an individual google account. In this case though this looks like a mailing list so it's unlikely to work anyway.
@jsuereth could you please suggest other individual emails to add here? Filtering these emails should be easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use [email protected] for now then.
friendly ping @jsuereth |
@g-easy would you be interested in continuous fuzzing for opencensus-cpp ?
This PR enables it with oss-fuzz with your fuzz targets.
It changes a bit the Basel build system to use https://github.com/bazelbuild/rules_fuzzing and https://google.github.io/oss-fuzz/getting-started/new-project-guide/bazel/ cf
cc @stefanbucur could
cc_fuzz_test
support corpus like it is used here https://github.com/census-instrumentation/opencensus-cpp/blob/ba631066779a534267fdb1321b19850eb2b0c000/opencensus/tags/BUILD#L194