Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bazel project opencensus-cpp #5533

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

catenacyber
Copy link
Contributor

@g-easy would you be interested in continuous fuzzing for opencensus-cpp ?
This PR enables it with oss-fuzz with your fuzz targets.
It changes a bit the Basel build system to use https://github.com/bazelbuild/rules_fuzzing and https://google.github.io/oss-fuzz/getting-started/new-project-guide/bazel/ cf

cc @stefanbucur could cc_fuzz_test support corpus like it is used here https://github.com/census-instrumentation/opencensus-cpp/blob/ba631066779a534267fdb1321b19850eb2b0c000/opencensus/tags/BUILD#L194

@stefanbucur
Copy link
Contributor

cc @stefanbucur could cc_fuzz_test support corpus like it is used here https://github.com/census-instrumentation/opencensus-cpp/blob/ba631066779a534267fdb1321b19850eb2b0c000/opencensus/tags/BUILD#L194

Yes, cc_fuzz_test already supports the corpus attribute in the same way: https://github.com/bazelbuild/rules_fuzzing/blob/master/docs/guide.md#specifying-seed-corpora

@g-easy
Copy link

g-easy commented Mar 31, 2021

Nice! Thanks for taking care of this.

@catenacyber
Copy link
Contributor Author

@g-easy I would need one (or more) mail for you to get the report about bugs
Could you provide one ?
This email address should be associated with a google account to access the detailed report

@g-easy
Copy link

g-easy commented Apr 1, 2021

@jsuereth - what would you suggest re: email address?

@jsuereth
Copy link

jsuereth commented Apr 7, 2021

sorry for delay, was out for a bit. [email protected] would be ideal for us.

@catenacyber catenacyber marked this pull request as ready for review April 7, 2021 20:10
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment about the email

@@ -0,0 +1,10 @@
homepage: "https://opencensus.io/"
language: c++
primary_contact: "[email protected]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the "+" breaks the auth for ClusterFuzz here, even if this was an email associated with an individual google account. In this case though this looks like a mailing list so it's unlikely to work anyway.

@jsuereth could you please suggest other individual emails to add here? Filtering these emails should be easy.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use [email protected] for now then.

@asraa
Copy link
Contributor

asraa commented Apr 15, 2021

friendly ping @jsuereth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants