Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[systemd] turn off AFL #5084

Closed
wants to merge 1 commit into from
Closed

[systemd] turn off AFL #5084

wants to merge 1 commit into from

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Feb 1, 2021

It seems AFLplusplus isn't compatible with meson. Since yesterday systemd has been
failing to build due to an unused command line argument:

Compiler stdout:

Compiler stderr:
 clang-12: error: /src/aflplusplus/afl-compiler-rt.o: 'linker' input unused [-Werror,-Wunused-command-line-argument]
clang-12: error: -Wl,--dynamic-list=/src/aflplusplus/dynamic_list.txt: 'linker' input unused [-Werror,-Wunused-command-line-argument]

meson.build:647:16: ERROR: Problem encountered: unable to determine gperf len type
+ exit 1

I'm not sure where the argument comes from but it looks like another variation on mesonbuild/meson#4542

It seems AFLplusplus isn't compatible with meson. Since yesterday systemd has been
failing to build due to an unused command line argument:

```
Compiler stdout:

Compiler stderr:
 clang-12: error: /src/aflplusplus/afl-compiler-rt.o: 'linker' input unused [-Werror,-Wunused-command-line-argument]
clang-12: error: -Wl,--dynamic-list=/src/aflplusplus/dynamic_list.txt: 'linker' input unused [-Werror,-Wunused-command-line-argument]

meson.build:647:16: ERROR: Problem encountered: unable to determine gperf len type
+ exit 1
```

I'm not sure where the argument comes from but it looks like another variation on mesonbuild/meson#4542
evverx added a commit to evverx/systemd that referenced this pull request Feb 1, 2021
@vanhauser-thc
Copy link
Contributor

vanhauser-thc commented Feb 1, 2021

IMHO the issue is -Werror - otherwise the instrumentation compiler would need more logic to identify which options are needed or not in a specific situation.
(the unused command line options comes from afl-clang-fast)

yuwata pushed a commit to systemd/systemd that referenced this pull request Feb 1, 2021
mrc0mmand pushed a commit to systemd-ci-incubator/systemd that referenced this pull request Feb 1, 2021
@inferno-chromium
Copy link
Collaborator

IMHO the issue is -Werror - otherwise the instrumentation compiler would need more logic to identify which options are needed or not in a specific situation.
(the unused command line options comes from afl-clang-fast)

Can this bug be fixed @vanhauser-thc , i guess projects can enable -Werror at will, so ideally the unused command line issue should be fixed in afl-clang-fast.

@evverx - instead of disabling AFL, can you try

export CC=clang
export CXX=clang++

i think that should fix this.

@inferno-chromium
Copy link
Collaborator

Closing as i plan to revert afl-clang-fast cl for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants