vulkan-loader: Use correct variable in destroy function #12881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit e17999e "fixed" the settings_fuzzer.c test by cleaning up memory, but did not pass in the correct variable. It would reinterpret a pointer to memory as a `loader_layer_list` struct, which is all sorts of wrong. It doesn't help that I forcibly cast the memory pointer to the loader_layer_list struct type, causing any warnings to be surpressed.
|
charles-lunarg is either the primary contact or is in the CCs list of projects/vulkan-loader. |
DavidKorczynski
approved these changes
Dec 26, 2024
charles-lunarg
deleted the
charles-lunarg/fix_vulkan_loader_enumerate_setting_fuzzer_again
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e17999e "fixed" the settings_fuzzer.c test by cleaning up memory, but did not pass in the correct variable. It would reinterpret a pointer to memory as a
loader_layer_liststruct, which is all sorts of wrong. It doesn't help that I forcibly cast the memory pointer to the loader_layer_list struct type, causing any warnings to be surpressed.@DavidKorczynski
2nd tries the charm hopefully.