Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade hiredis to fix Docker build: #12794

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Upgrade hiredis to fix Docker build: #12794

merged 1 commit into from
Nov 29, 2024

Conversation

oliverchang
Copy link
Collaborator

2024-11-29 14:01:13.657 AEDT
Step #0: clang -pthread -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -Ivendor -I/usr/local/include/python3.10 -c src/hiredis.c -o build/temp.linux-x86_64-cpython-310/src/hiredis.o
2024-11-29 14:01:13.657 AEDT
Step #0: error: command 'clang' failed: No such file or directory
2024-11-29 14:01:13.657 AEDT
Step #0: [end of output]
2024-11-29 14:01:13.657 AEDT
Step #0:
2024-11-29 14:01:13.657 AEDT
Step #0: note: This error originates from a subprocess, and is likely not a problem with pip.
2024-11-29 14:01:13.658 AEDT
Step #0: [0m[91m ERROR: Failed building wheel for hiredis
2024-11-29 14:01:13.659 AEDT
Step #0: [0m Running setup.py clean for hiredis
2024-11-29 14:01:14.059 AEDT
Step #0: Failed to build hiredis

Use a version that has a compatible prebuilt.

For #12772.

```
2024-11-29 14:01:13.657 AEDT
Step #0: clang -pthread -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -Ivendor -I/usr/local/include/python3.10 -c src/hiredis.c -o build/temp.linux-x86_64-cpython-310/src/hiredis.o
2024-11-29 14:01:13.657 AEDT
Step #0: error: command 'clang' failed: No such file or directory
2024-11-29 14:01:13.657 AEDT
Step #0: [end of output]
2024-11-29 14:01:13.657 AEDT
Step #0:
2024-11-29 14:01:13.657 AEDT
Step #0: note: This error originates from a subprocess, and is likely not a problem with pip.
2024-11-29 14:01:13.658 AEDT
Step #0: [0m[91m ERROR: Failed building wheel for hiredis
2024-11-29 14:01:13.659 AEDT
Step #0: [0m Running setup.py clean for hiredis
2024-11-29 14:01:14.059 AEDT
Step #0: Failed to build hiredis
```

Use a version that has a compatible prebuilt.

For #12772.
@oliverchang oliverchang merged commit 372224d into master Nov 29, 2024
18 of 19 checks passed
@oliverchang oliverchang deleted the upgrade-hiredis branch November 29, 2024 03:20
Copy link
Contributor

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants