infra: Fix jvm coverage report #12694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
Signed-off-by: Arthur Chan <[email protected]>
|
/gcbrun trial_build.py jvm --fuzzing-engines libfuzzer --sanitizers coverage |
DavidKorczynski
requested changes
Nov 13, 2024
| classes_dir=$DUMPS_DIR/classes | ||
| mkdir $classes_dir | ||
| for fuzz_target in $FUZZ_TARGETS; do | ||
| # Continue if not a fuzz target. | ||
| if [[ $FUZZING_ENGINE != "none" ]]; then |
There was a problem hiding this comment.
why delete if [[ $FUZZING_ENGINE != "none" ]]; then? We don't need this logic still?
|
/gcbrun trial_build.py jvm --fuzzing-engines libfuzzer --sanitizers coverage |
|
/gcbrun trial_build.py jvm --fuzzing-engines libfuzzer --sanitizers coverage |
1 similar comment
|
/gcbrun trial_build.py jvm --fuzzing-engines libfuzzer --sanitizers coverage |
|
The trial build is failing for some reason, and I can't reproduce: |
|
/gcbrun trial_build.py jvm --fuzzing-engines libfuzzer --sanitizers coverage |
|
I'm not sure why the trial build fails. It fails when building honggfuzz in the base-builder stage, however, I'm able to build the base builder locally without issues: |
|
Fix in #12807 |
|
/gcbrun trial_build.py jvm --fuzzing-engines libfuzzer --sanitizers coverage |
DavidKorczynski
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current JVM coverage calculation includes all class files and JAR files in $OUT. If the project has copied necessary dependency JAR files to $OUT for fuzzing purposes, those classes will also be included in the JaCoCo coverage report, adding noise. This PR addresses that issue by only copying class files located in the $OUT/$SRC directory, which are lively compiled from the project source code, ensuring that only project classes are used by jacoco-cli to generate the coverage report. As all JVM languages compile to class files, this approach should work for all JVM languages supported by OSS-Fuzz in general.