gitoxide: Use updated nightly to fix serde error #12512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EliahKagan is a new contributor to projects/gitoxide. The PR must be approved by known contributors before it can be merged. The past contributors are: alexcrichton, silvergasp, Byron |
Since around GitoxideLabs/gitoxide#1536, fuzzing is broken for `gitoxide` due to an error related to `serde`. As shown there and in GitoxideLabs/gitoxide#1596, the error is: error[E0658]: `#[diagnostic]` attribute name space is experimental --> /rust/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.210/src/de/mod.rs:536:5 | 536 | diagnostic::on_unimplemented( | ^^^^^^^^^^ | = note: see issue #111996 <rust-lang/rust#111996> for more information = help: add `#![feature(diagnostic_namespace)]` to the crate attributes to enable = note: this compiler was built on 2024-02-11; consider upgrading it if it is out of date Since rust-lang/rust#111996 is closed as completed, and similar errors appear to have been fixed in oss-fuzz for other projects by using the latest nightly toolchain, this makes the same change for `gitoxide` as was made in: - google#12404 for `starlark-rust` - google#12409 for `rhai` See also : - google#12410 - serde-rs/serde#2770
EliahKagan
force-pushed
the
fix-gitoxide
branch
from
e8dd8ab
to
facfab1
Compare
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Sep 18, 2024
…ml`" This reverts commit aafa8b1, since fuzzing doesn't use locked dependencies, so that's not a fix. See: - GitoxideLabs#1596 (comment) - google/oss-fuzz#12512
Byron
reviewed
Sep 18, 2024
DavidKorczynski
approved these changes
Sep 18, 2024
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Sep 18, 2024
…ml`" This reverts commit aafa8b1, since fuzzing doesn't use locked dependencies, so that's not a fix. See: - GitoxideLabs#1596 (comment) - google/oss-fuzz#12512
EliahKagan
added a commit
to EliahKagan/gitoxide
that referenced
this pull request
Sep 18, 2024
…ml`" This reverts commit aafa8b1, since fuzzing doesn't use locked dependencies, so that's not a fix. See: - GitoxideLabs#1596 (comment) - google/oss-fuzz#12512, which does fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since around GitoxideLabs/gitoxide#1536, fuzzing is broken for
gitoxidedue to an error related toserde. As shown there and in GitoxideLabs/gitoxide#1596, the error is:Since rust-lang/rust#111996 is closed as completed, and similar errors appear to have been fixed in oss-fuzz for other projects by using the latest nightly toolchain, this makes the same change for
gitoxideas was made in:starlark-rustrhaiSee also:
cc @Byron