-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: print log data when Python fuzz_target fails #12502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2024
correctmost
force-pushed
the
display-coverage-log
branch
2 times, most recently
from
September 27, 2024 21:22
defafdb
to
8ccd721
Compare
@jonathanmetzman can you trigger a trial build? I think this change should be safe. Thanks! |
/gcbrun trial_build.py python |
I verified that log data is now printed for Python coverage failures: Project: bleach
|
This will make it easier to debug coverage failures that are not reproducible locally.
correctmost
force-pushed
the
display-coverage-log
branch
from
October 3, 2024 00:56
8ccd721
to
ce01782
Compare
/gcbrun trial_build.py python |
vitorguidi
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will make it easier to debug coverage failures that are not reproducible locally.
The failure that I am trying to debug:
Similar log data is displayed in other blocks:
oss-fuzz/infra/base-images/base-runner/coverage
Lines 101 to 105 in f716590
oss-fuzz/infra/base-images/base-runner/coverage
Lines 149 to 153 in f716590
oss-fuzz/infra/base-images/base-runner/coverage
Lines 206 to 210 in f716590
oss-fuzz/infra/base-images/base-runner/coverage
Lines 255 to 260 in f716590
This PR is a continuation of #12405 with a renamed branch to avoid trial-build errors: