Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pygments] Upgrade pip to fix broken build #11764

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

DaveLak
Copy link
Contributor

@DaveLak DaveLak commented Mar 31, 2024

It looks like the pygments build has the same toml parsing issue as I described in c3bedd8, i.e. the outdated pip was unable to parse pyproject.toml syntax.

But curiously, the this hasn't been an issue until the most recent (at the time of writing) build on 2024-03-30 log and prior builds (e.g. 2024-03-29 log) listed on https://oss-fuzz-build-logs.storage.googleapis.com/index.html#pygments seem to have been fine?

I wonder if something changed somewhere and more projects that don't upgrade pip will begin failing?

In any case, this fixes the build. Tested locally with python infra/helper.py check_build pygments.

The pre-installed version of `pip` (19.2.3) was outdated and unable to
parse the `pyproject.toml` syntax during the install step in `build.sh`
causing the script to error out and crash the build.

Upgrading `pip` to the latest version in the project image resolves the
issue and allows the installation to complete.
Copy link

DaveLak is a new contributor to projects/pygments. The PR must be approved by known contributors before it can be merged. The past contributors are: jvoisin, Google-Autofuzz, TheShiftedBit, fmeum, birkenfeld

@maflcko
Copy link
Contributor

maflcko commented Apr 2, 2024

cc @jvoisin

@jvoisin
Copy link
Contributor

jvoisin commented Apr 2, 2024

Shouldn't this be fixed in the base image, instead of having to add the same line in every python project when the issue arises?

@DaveLak
Copy link
Contributor Author

DaveLak commented Apr 2, 2024

Shouldn't this be fixed in the base image, instead of having to add the same line in every python project when the issue arises?

Yes, I think so, and #11420 looks like it would do just that (in addition to resolving other Python dependency issues, e.g., #11742.

However, given the complexity of the ongoing clang-18 upgrade in #11714, the change proposed here felt like the best way to keep pygments fuzzers productive until the dust settles and bandwidth is available to introduce a more comprehensive solution.

@jvoisin
Copy link
Contributor

jvoisin commented Apr 2, 2024

Those hacks will stay in place even after clang-18 happens, but I guess the amount of resources consumed by upgrading pip is negligible compared to running fuzzers, so LGTM.

@DonggeLiu DonggeLiu merged commit e6daa20 into google:master Apr 18, 2024
16 checks passed
@DaveLak DaveLak deleted the fix-pygments-build branch April 18, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants