Apache POI: Improve coverage counting and add a few more expected exceptions #11418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some were added in Apache POI recently (cherry picked from commit 2dae2bc1d0cde0c797365b51488e47cae7ad15a5)
…included in coverage report Introduce two jar-files to separate .class files into two jar files, one which is included in coverage reporting and one which contains libraries which should not appear in the coverage report. Unfortunately this only allows control on "artifact" level, which means single uninteresting classes/packages cannot be excluded. Related to google#10826 and google#10860 (cherry picked from commit 2b48e656646d4c3aa61ea44b5b3edef59942f142)
Otherwise we cannot avoid OOM with the value of Xmx that is used by oss-fuzz (cherry picked from commit fef7859f75eb501c305c2cd53c0c6ac00440db3b)
|
centic9 has previously contributed to projects/apache-poi. The previous PR was #11107 |
DavidKorczynski
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a general solution for handling excluding classes from JaCoCo coverage counting was not merged (See #10860#issuecomment-1870891873 ), this PR tries to implement a different approach which separates the class-files into two jar-files and this way at least allows to exclude code of third-party libraries when reporting coverage of fuzzing.
Also add two expected exceptions and adjust one limit to match the amount of memory which oss-fuzz uses here.