-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typst: Initial integration #11197
typst: Initial integration #11197
Conversation
silvergasp is integrating a new project: |
cc @laurmaedje, this is pretty much ready to be integrated once typst/typst#2581 is merged. TODOs:
|
As primary contact, I approve this integration. |
e146546
to
1c10acb
Compare
Thanks @laurmaedje, there where a few changes I needed to make, to match the upstream changes. But this is all good to go now. Just got to wait on approval from the oss-fuzz team. |
If you are reviewing this and are not familiar with typst. Typst is a modern typesetting language akin to LaTex. It roughly fills the same niche but it is a lot faster and nicer to use. Typst is a very popular project and has 23.7k stars on github. |
Friendly ping @jonathanmetzman, thoughts on this one? |
I'll ask, but if you could point to specific users (e.g. users from University of X) it would be better. |
Easy, I know some of my old colleagues at Curtin University are using typst for some of their papers. But I'd have to defer to @laurmaedje for more information on broader adoption. |
1c10acb
to
4d46803
Compare
4d46803
to
32f0275
Compare
I'm not sure how much usage is needed to quality for oss-fuzz, but as a point of reference, I've just checked the database of our web app (typst.app) and it has registered users from ~300 distinct .edu university domains. There are more if you count non-.edu universities, but that was a quick and simple metric. For something that's easier to verify, there is GitHub (24.7k stars, 216 unique contributors) and Discord activity (~6000 members on the Discord server). |
This should keep the CI happy.
I'll ask the committee if we approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jonathanmetzman I've gotten a few emails from ClusterFuzz since this has been merged and have two questions:
|
@laurmaedje I'm able to access these bugs on bugs.chromium.org. Can you confirm that this email is correct? https://github.com/google/oss-fuzz/pull/11197/files#diff-3c33f15cfcdce4e7819a1159de2a946fe40a33523d4c0073cf5251e19d8c945eR3 |
The email is correct. The only difference to my bugs.chromium.com account is the gmail vs googlemail domain. But it doesn't seem like I can change it, since bugs.chromium.com is just "Login with Google". |
Yeah, that's what I mean. The bug is sent to laurmaedje (at) gmail.com, but the actual bugs.chromium.com account linked to my Google account is under laurmaedje (at) googlemail.com and I have no way of changing it. |
Are you able to login at ossfuzz.com ? |
Yes, that works. Though not via "Login with Google", but rather via "Login with GitHub". |
That's strange if you just go to https://bugs.chromium.org/ are you able to sign in (top right) with your gmail account? |
I can log in, but if I open any of the non-disclosed issues, I get "Permission denied.". I really think the cause is that my bugs.chromium.org account ends with googlemail.com and the thing in the issue is gmail.com. |
Aight, I just got your email back I think I can fix this pretty easily. |
No description provided.