Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typst: Initial integration #11197

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

nathaniel-brough
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 7, 2023

silvergasp is integrating a new project:
- Main repo: https://github.com/typst/typst.git
- Criticality score: 0.64487

@nathaniel-brough
Copy link
Contributor Author

nathaniel-brough commented Nov 7, 2023

cc @laurmaedje, this is pretty much ready to be integrated once typst/typst#2581 is merged.

TODOs:

  • Switch from silvergasp fork -> typst main branch

@laurmaedje
Copy link
Contributor

As primary contact, I approve this integration.

@nathaniel-brough nathaniel-brough force-pushed the typst branch 3 times, most recently from e146546 to 1c10acb Compare December 5, 2023 23:15
@nathaniel-brough nathaniel-brough marked this pull request as ready for review December 5, 2023 23:47
@nathaniel-brough
Copy link
Contributor Author

Thanks @laurmaedje, there where a few changes I needed to make, to match the upstream changes. But this is all good to go now. Just got to wait on approval from the oss-fuzz team.

@nathaniel-brough
Copy link
Contributor Author

If you are reviewing this and are not familiar with typst. Typst is a modern typesetting language akin to LaTex. It roughly fills the same niche but it is a lot faster and nicer to use. Typst is a very popular project and has 23.7k stars on github.

@nathaniel-brough
Copy link
Contributor Author

Friendly ping @jonathanmetzman, thoughts on this one?

projects/typst/build.sh Outdated Show resolved Hide resolved
@jonathanmetzman
Copy link
Contributor

Friendly ping @jonathanmetzman, thoughts on this one?

I'll ask, but if you could point to specific users (e.g. users from University of X) it would be better.

@nathaniel-brough
Copy link
Contributor Author

I'll ask, but if you could point to specific users (e.g. users from University of X) it would be better.

Easy, I know some of my old colleagues at Curtin University are using typst for some of their papers. But I'd have to defer to @laurmaedje for more information on broader adoption.

@laurmaedje
Copy link
Contributor

I'll ask, but if you could point to specific users (e.g. users from University of X) it would be better.

I'm not sure how much usage is needed to quality for oss-fuzz, but as a point of reference, I've just checked the database of our web app (typst.app) and it has registered users from ~300 distinct .edu university domains. There are more if you count non-.edu universities, but that was a quick and simple metric.

For something that's easier to verify, there is GitHub (24.7k stars, 216 unique contributors) and Discord activity (~6000 members on the Discord server).

This should keep the CI happy.
@jonathanmetzman
Copy link
Contributor

I'll ask the committee if we approve.

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman jonathanmetzman merged commit 3feac6b into google:master Jan 12, 2024
15 checks passed
@laurmaedje
Copy link
Contributor

@jonathanmetzman I've gotten a few emails from ClusterFuzz since this has been merged and have two questions:

  1. I can't access the issues on bugs.chromium.org (I get permission denied). I noticed that the emails state my (at)gmail.com address while bugs.chromium.org displays (at)googlemail.com, but it might not be related to that.

  2. Clusterfuzz keeps reporting new stack overflow issues in Typst's recursive descent parser, which are conceptually all the same issue. Is there some way to instruct it to not keep opening new issues for that?

@nathaniel-brough
Copy link
Contributor Author

@laurmaedje I'm able to access these bugs on bugs.chromium.org. Can you confirm that this email is correct? https://github.com/google/oss-fuzz/pull/11197/files#diff-3c33f15cfcdce4e7819a1159de2a946fe40a33523d4c0073cf5251e19d8c945eR3

@laurmaedje
Copy link
Contributor

The email is correct. The only difference to my bugs.chromium.com account is the gmail vs googlemail domain. But it doesn't seem like I can change it, since bugs.chromium.com is just "Login with Google".

@nathaniel-brough
Copy link
Contributor Author

That's strange when I look on bugs.chromium.com it has your gmail account listed. I don't see anything there about a googlemail domain.

image

@laurmaedje
Copy link
Contributor

laurmaedje commented Jan 17, 2024

Yeah, that's what I mean. The bug is sent to laurmaedje (at) gmail.com, but the actual bugs.chromium.com account linked to my Google account is under laurmaedje (at) googlemail.com and I have no way of changing it.

@nathaniel-brough
Copy link
Contributor Author

Are you able to login at ossfuzz.com ?

@laurmaedje
Copy link
Contributor

Are you able to login at ossfuzz.com ?

Yes, that works. Though not via "Login with Google", but rather via "Login with GitHub".

@nathaniel-brough
Copy link
Contributor Author

That's strange if you just go to https://bugs.chromium.org/ are you able to sign in (top right) with your gmail account?

@laurmaedje
Copy link
Contributor

I can log in, but if I open any of the non-disclosed issues, I get "Permission denied.". I really think the cause is that my bugs.chromium.org account ends with googlemail.com and the thing in the issue is gmail.com.

@nathaniel-brough
Copy link
Contributor Author

Aight, I just got your email back I think I can fix this pretty easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants