Fix Dockerfile rewrite for using cached builds. #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbun exp -n ochang-test |
|
/gcbrun exp -n ochang-test |
We weren't keeping the ARG, WORKDIR lines. ARG is necessary for obvious reasons since we are relying on injecting the base image at runtime. WORKDIR is required for: https://github.com/google/oss-fuzz/blob/edfa6730fa9f1dca77dd27c0b3a643171e082950/infra/build/functions/build_project.py#L229
oliverchang
force-pushed
the
fix-cloud-cached
branch
from
94a3ee2 to
b8ece86
Compare
|
/gcbrun exp -n ochang-test |
DonggeLiu
approved these changes
Nov 7, 2024
|
I think this works, but there needs to be another change to the oss-fuzz build infra side to use the cached coverage image as well. I'll do that in a followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't keeping the ARG, WORKDIR lines.
ARG is necessary for obvious reasons since we are relying on injecting
the base image at runtime.
WORKDIR is required for: https://github.com/google/oss-fuzz/blob/edfa6730fa9f1dca77dd27c0b3a643171e082950/infra/build/functions/build_project.py#L229