Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit OS stdio in curl command #147

Merged
merged 2 commits into from
Jan 15, 2023
Merged

Conversation

timdp
Copy link
Contributor

@timdp timdp commented Jan 4, 2023

Fixes #146.

@google-cla
Copy link

google-cla bot commented Jan 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@timdp
Copy link
Contributor Author

timdp commented Jan 4, 2023

Apologies for the force-pushes. I thought I needed to change the email address on the commit to have the CLA check pick up on it.

@andyrzhao andyrzhao self-requested a review January 7, 2023 07:05
Copy link
Collaborator

@andyrzhao andyrzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I think the cli_test needs some small updates to run curl in silent mode (-s) so it doesn't print out the progress. I'm curious as to why it didn't show up in the output buffer before though?

@timdp
Copy link
Contributor Author

timdp commented Jan 9, 2023

Oh, sorry. When go test didn't do anything, I assumed there were no tests, but I should have checked the Makefile or integration folder.

I've added -s to the curl command in the tests to re-match stdout with the snapshots. Test are passing again now.

Alternatively, I suppose we could inspect curl's default output, but that would also involve normalizing the URL and progress bar before snapshotting.

@andyrzhao andyrzhao self-requested a review January 15, 2023 04:18
@andyrzhao andyrzhao merged commit 21ab08b into google:master Jan 15, 2023
@DavidDTA
Copy link

This was merged almost 2 years ago, but there has been no release since then to make it available. Is there any chance a new release could be created?

@andyrzhao
Copy link
Collaborator

Yes, I can try to push out updated releases for all platforms. ETA end of this year at the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

curl stdout goes to oauth2l stderr
3 participants