-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit OS stdio in curl command #147
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Apologies for the force-pushes. I thought I needed to change the email address on the commit to have the CLA check pick up on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I think the cli_test needs some small updates to run curl in silent mode (-s) so it doesn't print out the progress. I'm curious as to why it didn't show up in the output buffer before though?
Oh, sorry. When I've added Alternatively, I suppose we could inspect curl's default output, but that would also involve normalizing the URL and progress bar before snapshotting. |
This was merged almost 2 years ago, but there has been no release since then to make it available. Is there any chance a new release could be created? |
Yes, I can try to push out updated releases for all platforms. ETA end of this year at the latest. |
Fixes #146.