-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix browser test errs on mac #630
base: master
Are you sure you want to change the base?
Fix browser test errs on mac #630
Conversation
Thanks! Does this allow the WebGL tests to pass in Github actions on macOS? (See 33f5eb5#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721) |
I'm not sure - I just removed the if statement in the GitHub action to allow the tests including WebGL to run. |
It looks like this still does not allow the tests to pass on macOS on github actions, but hopefully it will work in the future after microsoft/playwright#30585 is fixed. Per the description here (https://playwright.dev/docs/library#key-differences) does it work to just add @playwright/browser-chromium as a dev dependency rather than having to do |
In the latest commit, I tested adding @playwright/browser-chromim as a dev dependency and removing |
Would adding |
@mkitti Which version of the PR did you get this error from? Is this after I added @playwright/browser-chromium as a dev dependency? |
Yes. You can see it in the Github Actions tests for client (macos-latest): |
Added |
Addresses issue #627.
playwright
as a dependency; removeswebdriverio
.playwright
as the browser provider rather thanwebdriverio
.npx playwright install
to thetest
andtest:watch
commands in package.json. This is to ensure playwright updates after the initial install, to avoid getting the error Error: browserType.launch, followed the by the instructions: "Looks like Playwright Test or Playwright was just installed or updated. Please run the following command to download new browsers: npx playwright install.All tests pass in macOS 14.5 using this configuration.
Replaces PR #628. These commits use the correct email address associated with the Janelia CLA.