Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong column order in aux dictionary #928

Merged
merged 1 commit into from
May 13, 2024

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented May 12, 2024

Description

The rows for "対象外" & "対象内" in aux_dictionary.tsv have wrong column order.

Issue IDs

Issue and/or discussion IDs related to this pull request.

Steps to test new behaviors (if any)

A clear and concise description about how to verify new behaviors (if any).

  • OS: any
  • Steps:
    1. Input "対象外" or "対象内"
    2. Compose
    3. Confirm both of them are treated as single words

Additional context

Add any other context about the pull request here.

@hiroyuki-komatsu hiroyuki-komatsu merged commit 6ba364e into google:master May 13, 2024
1 check passed
@hiroyuki-komatsu
Copy link
Collaborator

Hi tsts-u,

We have merged your change.
Thank you for your contributions!

@tats-u tats-u deleted the fix-taisho branch May 13, 2024 08:46
hiroyuki-komatsu added a commit that referenced this pull request Jun 6, 2024
Features
* Added more symbol characters (#933)
* Added words of 対象内 / 対象外 by fixing the format error (#928)

Bug fix
* Fixed the crash issue on saving the user dictionary. (42cbb3f)
* Fixed the crash issue on the debug build caused by converting negative numbers (#878)
* macOS: Replaced "Google Japanese Input" with Mozc in UI messages. (caeb9ce)
* macOS: Fixed the crash issue of mozc_emacs_helper (#900)
* macOS (Apple Silicon): Fixed the crash issue of GUI tools (#791)

Build
* Set proper release/debug build options for GitHub Actions (07c5f89)
* Updated the Protobuf version: v26.1 → v27.0 (#937)
* Updated the Qt version: 6.7.0 → 6.7.1 (#934)
* Linux: Added Dockerfile for Ubuntu 24.04 (#924)
* Windows: Simplified the build process by reducing manual execution of the vcvars .bat file. (#923)

Code
* Applied Clang's build cleaner
* Completed the migration from base/logging.h to Abseil log.
* macOS: Applied suggestions from code scanning alerts (b955086)

PiperOrigin-RevId: 639975159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants